Changeset 244690 in webkit


Ignore:
Timestamp:
Apr 26, 2019 9:32:25 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
https://bugs.webkit.org/show_bug.cgi?id=197303

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-04-26
Reviewed by Alex Christensen.

Source/WebCore:

Therefore SVGElement::propertyRegistry() was called instead. This means
these two elements will not have access to the properties of the base
class SVGFilterPrimitiveStandardAttributes.

Tests: svg/dom/SVGFEFloodElement-filter-standard-attributes.svg

  • svg/SVGElement.cpp:

(WebCore::SVGElement::commitPropertyChange):

  • svg/SVGFEFloodElement.h:
  • svg/SVGFEMergeElement.h:

LayoutTests:

  • svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg: Added.
  • svg/dom/SVGFEFloodElement-filter-standard-attributes.svg: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r244689 r244690  
     12019-04-26  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
     4        https://bugs.webkit.org/show_bug.cgi?id=197303
     5
     6        Reviewed by Alex Christensen.
     7
     8        * svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg: Added.
     9        * svg/dom/SVGFEFloodElement-filter-standard-attributes.svg: Added.
     10
    1112019-04-26  Youenn Fablet  <youenn@apple.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r244689 r244690  
     12019-04-26  Said Abou-Hallawa  <sabouhallawa@apple.com>
     2
     3        propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement
     4        https://bugs.webkit.org/show_bug.cgi?id=197303
     5
     6        Reviewed by Alex Christensen.
     7
     8        Therefore SVGElement::propertyRegistry() was called instead. This means
     9        these two elements will not have access to the properties of the base
     10        class SVGFilterPrimitiveStandardAttributes.
     11
     12        Tests: svg/dom/SVGFEFloodElement-filter-standard-attributes.svg
     13
     14        * svg/SVGElement.cpp:
     15        (WebCore::SVGElement::commitPropertyChange):
     16        * svg/SVGFEFloodElement.h:
     17        * svg/SVGFEMergeElement.h:
     18
    1192019-04-26  Youenn Fablet  <youenn@apple.com>
    220
  • trunk/Source/WebCore/svg/SVGElement.cpp

    r243830 r244690  
    584584{
    585585    QualifiedName attributeName = propertyRegistry().animatedPropertyAttributeName(animatedProperty);
     586    ASSERT(attributeName != nullQName());
    586587
    587588    // A change in a style property, e.g SVGRectElement::x should be serialized to
  • trunk/Source/WebCore/svg/SVGFEFloodElement.h

    r243185 r244690  
    3333    SVGFEFloodElement(const QualifiedName&, Document&);
    3434
     35    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEFloodElement, SVGFilterPrimitiveStandardAttributes>;
     36    const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
     37
    3538    bool setFilterEffectAttribute(FilterEffect*, const QualifiedName& attrName) override;
    3639    RefPtr<FilterEffect> build(SVGFilterBuilder*, Filter&) const override;
     40
     41    PropertyRegistry m_propertyRegistry { *this };
    3742};
    3843
  • trunk/Source/WebCore/svg/SVGFEMergeElement.h

    r243185 r244690  
    3333    SVGFEMergeElement(const QualifiedName&, Document&);
    3434
     35    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEMergeElement, SVGFilterPrimitiveStandardAttributes>;
     36    const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
     37
    3538    RefPtr<FilterEffect> build(SVGFilterBuilder*, Filter&) const override;
     39
     40    PropertyRegistry m_propertyRegistry { *this };
    3641};
    3742
Note: See TracChangeset for help on using the changeset viewer.