Changeset 244690 in webkit
- Timestamp:
- Apr 26, 2019 9:32:25 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r244689 r244690 1 2019-04-26 Said Abou-Hallawa <sabouhallawa@apple.com> 2 3 propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement 4 https://bugs.webkit.org/show_bug.cgi?id=197303 5 6 Reviewed by Alex Christensen. 7 8 * svg/dom/SVGFEFloodElement-filter-standard-attributes-expected.svg: Added. 9 * svg/dom/SVGFEFloodElement-filter-standard-attributes.svg: Added. 10 1 11 2019-04-26 Youenn Fablet <youenn@apple.com> 2 12 -
trunk/Source/WebCore/ChangeLog
r244689 r244690 1 2019-04-26 Said Abou-Hallawa <sabouhallawa@apple.com> 2 3 propertyRegistry() was not overridden for SVGFEFloodElement and SVGFEMergeElement 4 https://bugs.webkit.org/show_bug.cgi?id=197303 5 6 Reviewed by Alex Christensen. 7 8 Therefore SVGElement::propertyRegistry() was called instead. This means 9 these two elements will not have access to the properties of the base 10 class SVGFilterPrimitiveStandardAttributes. 11 12 Tests: svg/dom/SVGFEFloodElement-filter-standard-attributes.svg 13 14 * svg/SVGElement.cpp: 15 (WebCore::SVGElement::commitPropertyChange): 16 * svg/SVGFEFloodElement.h: 17 * svg/SVGFEMergeElement.h: 18 1 19 2019-04-26 Youenn Fablet <youenn@apple.com> 2 20 -
trunk/Source/WebCore/svg/SVGElement.cpp
r243830 r244690 584 584 { 585 585 QualifiedName attributeName = propertyRegistry().animatedPropertyAttributeName(animatedProperty); 586 ASSERT(attributeName != nullQName()); 586 587 587 588 // A change in a style property, e.g SVGRectElement::x should be serialized to -
trunk/Source/WebCore/svg/SVGFEFloodElement.h
r243185 r244690 33 33 SVGFEFloodElement(const QualifiedName&, Document&); 34 34 35 using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEFloodElement, SVGFilterPrimitiveStandardAttributes>; 36 const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; } 37 35 38 bool setFilterEffectAttribute(FilterEffect*, const QualifiedName& attrName) override; 36 39 RefPtr<FilterEffect> build(SVGFilterBuilder*, Filter&) const override; 40 41 PropertyRegistry m_propertyRegistry { *this }; 37 42 }; 38 43 -
trunk/Source/WebCore/svg/SVGFEMergeElement.h
r243185 r244690 33 33 SVGFEMergeElement(const QualifiedName&, Document&); 34 34 35 using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEMergeElement, SVGFilterPrimitiveStandardAttributes>; 36 const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; } 37 35 38 RefPtr<FilterEffect> build(SVGFilterBuilder*, Filter&) const override; 39 40 PropertyRegistry m_propertyRegistry { *this }; 36 41 }; 37 42
Note: See TracChangeset
for help on using the changeset viewer.