Changeset 244789 in webkit

Timestamp:

Apr 30, 2019 11:33:30 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Parse and display bindings test failures
​https://bugs.webkit.org/show_bug.cgi?id=197423

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-build/steps.py:

(RunBindingsTests.init): Set timeout of 5 minutes.
(RunBindingsTests.start): Initialize log_observer for json output.
(RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
(RunBindingsTests._addToLog): Method to add message to log.

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -468 +468 @@
     command = ['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(jsonFileName)]
 
+    def __init__(self, **kwargs):
+        super(RunBindingsTests, self).__init__(timeout=5 * 60, **kwargs)
+
+    def start(self):
+        self.log_observer = logobserver.BufferLogObserver()
+        self.addLogObserver('json', self.log_observer)
+        return shell.ShellCommand.start(self)
+
+    def getResultSummary(self):
+        if self.results == SUCCESS:
+            message = 'Passed bindings tests'
+            self.build.buildFinished([message], SUCCESS)
+            return {u'step': unicode(message)}
+
+        logLines = self.log_observer.getStdout()
+        json_text = ''.join([line for line in logLines.splitlines()])
+        try:
+            webkitpy_results = json.loads(json_text)
+        except Exception as ex:
+            self._addToLog('stderr', 'ERROR: unable to parse data, exception: {}'.format(ex))
+            return super(RunBindingsTests, self).getResultSummary()
+
+        failures = webkitpy_results.get('failures')
+        if not failures:
+            return super(RunBindingsTests, self).getResultSummary()
+        pluralSuffix = 's' if len(failures) > 1 else ''
+        failures_string = ', '.join([failure.replace('(JS) ', '') for failure in failures])
+        message = 'Found {} Binding test failure{}: {}'.format(len(failures), pluralSuffix, failures_string)
+        self.build.buildFinished([message], FAILURE)
+        return {u'step': unicode(message)}
+
+    @defer.inlineCallbacks
+    def _addToLog(self, logName, message):
+        try:
+            log = self.getLog(logName)
+        except KeyError:
+            log = yield self.addLog(logName)
+        log.addStdout(message)
+
 
 class RunWebKitPerlTests(shell.ShellCommand):

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -295 +295 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=300,
                         command=['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
                         logfiles={'json': self.jsonFileName},
@@ -300 +301 @@
             + 0,
         )
-        self.expectOutcome(result=SUCCESS, state_string='bindings-tests')
+        self.expectOutcome(result=SUCCESS, state_string='Passed bindings tests')
         return self.runStep()
 
@@ -307 +308 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
+                        timeout=300,
                         command=['Tools/Scripts/run-bindings-tests', '--json-output={0}'.format(self.jsonFileName)],
                         logfiles={'json': self.jsonFileName},

trunk/Tools/ChangeLog

@@ +1 @@
+2019-04-30  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Parse and display bindings test failures
+        https://bugs.webkit.org/show_bug.cgi?id=197423
+
+        Reviewed by Lucas Forschler.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (RunBindingsTests.__init__): Set timeout of 5 minutes.
+        (RunBindingsTests.start): Initialize log_observer for json output.
+        (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
+        (RunBindingsTests._addToLog): Method to add message to log.
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
+
 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>