Changeset 245008 in webkit


Ignore:
Timestamp:
May 7, 2019 7:33:47 AM (5 years ago)
Author:
Carlos Garcia Campos
Message:

[GTK] Crash in webkitWebViewBaseSetEnableBackForwardNavigationGesture
https://bugs.webkit.org/show_bug.cgi?id=197653

Reviewed by Žan Doberšek.

We still need to null-check the ViewGestureController there, since it can be called with a running process but
not yet attached when using a related view.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetEnableBackForwardNavigationGesture):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r245006 r245008  
     12019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        [GTK] Crash in webkitWebViewBaseSetEnableBackForwardNavigationGesture
     4        https://bugs.webkit.org/show_bug.cgi?id=197653
     5
     6        Reviewed by Žan Doberšek.
     7
     8        We still need to null-check the ViewGestureController there, since it can be called with a running process but
     9        not yet attached when using a related view.
     10
     11        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
     12        (webkitWebViewBaseSetEnableBackForwardNavigationGesture):
     13
    1142019-05-07  Antti Koivisto  <antti@apple.com>
    215
  • trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp

    r244744 r245008  
    11971197    priv->isBackForwardNavigationGestureEnabled = enabled;
    11981198
    1199     if (priv->pageProxy->hasRunningProcess())
    1200         webViewBase->priv->viewGestureController->setSwipeGestureEnabled(enabled);
     1199    if (auto* controller = webkitWebViewBaseViewGestureController(webViewBase))
     1200        controller->setSwipeGestureEnabled(enabled);
    12011201
    12021202    priv->pageProxy->setShouldRecordNavigationSnapshots(enabled);
Note: See TracChangeset for help on using the changeset viewer.