Changeset 245019 in webkit

Timestamp:

May 7, 2019 11:42:16 AM (5 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r244900.

Caused media/track/track-cue-missing.html to fail on debug
queues

Reverted changeset:

"Add logging for RenderLayer clip rects"
​https://bugs.webkit.org/show_bug.cgi?id=197547
​https://trac.webkit.org/changeset/244900

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/Logging.h (modified) (1 diff)
• rendering/ClipRect.cpp (modified) (1 diff)
• rendering/ClipRect.h (modified) (2 diffs)
• rendering/RenderLayer.cpp (modified) (5 diffs)
• rendering/RenderLayer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r244900.
+
+        Caused media/track/track-cue-missing.html to fail on debug
+        queues
+
+        Reverted changeset:
+
+        "Add logging for RenderLayer clip rects"
+        https://bugs.webkit.org/show_bug.cgi?id=197547
+        https://trac.webkit.org/changeset/244900
+
 2019-05-07  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/platform/Logging.h

@@ -43 +43 @@
     M(ApplePay) \
     M(Archives) \
-    M(ClipRects) \
     M(Compositing) \
     M(ContentFiltering) \

trunk/Source/WebCore/rendering/ClipRect.cpp

@@ -39 +39 @@
 }
 
-TextStream& operator<<(TextStream& ts, const ClipRect& clipRect)
-{
-    ts << "rect ";
-    if (clipRect.isInfinite())
-        ts << "infinite";
-    else
-        ts << clipRect.rect();
-
-    if (clipRect.affectedByRadius())
-        ts << " affected by radius";
-    return ts;
 }
-
-}

trunk/Source/WebCore/rendering/ClipRect.h

@@ -27 +27 @@
 
 #include "LayoutRect.h"
-
-namespace WTF {
-class TextStream;
-}
 
 namespace WebCore {
@@ -108 +104 @@
 }
 
-WTF::TextStream& operator<<(WTF::TextStream&, const ClipRect&);
-
 } // namespace WebCore

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -269 +269 @@
 }
 
-#if !LOG_DISABLED
-static TextStream& operator<<(TextStream& ts, const ClipRects& clipRects)
-{
-    TextStream::GroupScope scope(ts);
-    ts << indent << "ClipRects\n";
-    ts << indent << "  overflow  : " << clipRects.overflowClipRect() << "\n";
-    ts << indent << "  fixed     : " << clipRects.fixedClipRect() << "\n";
-    ts << indent << "  positioned: " << clipRects.posClipRect() << "\n";
-
-    return ts;
-}
-#endif
-
 RenderLayer::RenderLayer(RenderLayerModelObject& rendererLayerModelObject)
     : m_isRenderViewLayer(rendererLayerModelObject.isRenderView())
@@ -5542 +5529 @@
         }
     }
-    
-    LOG_WITH_STREAM(ClipRects, stream << "RenderLayer " << this << " calculateClipRects " << clipRects);
 }
 
@@ -5593 +5578 @@
     if (parentRects->fixed() && &clipRectsContext.rootLayer->renderer() == &view && !backgroundClipRect.isInfinite())
         backgroundClipRect.moveBy(view.frameView().scrollPositionForFixedPosition());
-
-    LOG_WITH_STREAM(ClipRects, stream << "RenderLayer " << this << " backgroundClipRect with context " << clipRectsContext << " returning " << backgroundClipRect);
     return backgroundClipRect;
 }
@@ -6757 +6740 @@
 }
 
-TextStream& operator<<(WTF::TextStream& ts, ClipRectsType clipRectsType)
-{
-    switch (clipRectsType) {
-    case PaintingClipRects: ts << "painting"; break;
-    case RootRelativeClipRects: ts << "root-relative"; break;
-    case AbsoluteClipRects: ts << "absolute"; break;
-    case TemporaryClipRects: ts << "temporary"; break;
-    case NumCachedClipRectsTypes:
-    case AllClipRectTypes:
-        ts << "?";
-        break;
-    }
-    return ts;
-}
-
 TextStream& operator<<(TextStream& ts, const RenderLayer& layer)
 {
@@ -6790 +6758 @@
 }
 
-TextStream& operator<<(TextStream& ts, const RenderLayer::ClipRectsContext& context)
-{
-    ts.dumpProperty("root layer:", context.rootLayer);
-    ts.dumpProperty("type:", context.clipRectsType);
-    ts.dumpProperty("overflow-clip:", context.respectOverflowClip == IgnoreOverflowClip ? "ignore" : "respect");
-    
-    return ts;
-}
-
 } // namespace WebCore
 

trunk/Source/WebCore/rendering/RenderLayer.h

@@ -1370 +1370 @@
 bool compositedWithOwnBackingStore(const RenderLayer&);
 
-WTF::TextStream& operator<<(WTF::TextStream&, ClipRectsType);
 WTF::TextStream& operator<<(WTF::TextStream&, const RenderLayer&);
-WTF::TextStream& operator<<(WTF::TextStream&, const RenderLayer::ClipRectsContext&);
 
 } // namespace WebCore