Changeset 245202 in webkit

Timestamp:

May 10, 2019 5:39:58 PM (5 years ago)

Author:

sbarati@apple.com

Message:

Bag's move operator= leaks memory
​https://bugs.webkit.org/show_bug.cgi?id=197757

Reviewed by Keith Miller.

It was unused. So I'm just removing it. We can implement it properly
if we ever need it.

• wtf/Bag.h:

(WTF::Bag::operator=): Deleted.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Bag.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-05-10  Saam barati  <sbarati@apple.com>
+
+        Bag's move operator= leaks memory
+        https://bugs.webkit.org/show_bug.cgi?id=197757
+
+        Reviewed by Keith Miller.
+
+        It was unused. So I'm just removing it. We can implement it properly
+        if we ever need it.
+
+        * wtf/Bag.h:
+        (WTF::Bag::operator=): Deleted.
+
 2019-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WTF/wtf/Bag.h

@@ -66 +66 @@
     }
 
-    template<typename U>
-    Bag& operator=(Bag<T, U>&& other)
-    {
-        m_head = other.unwrappedHead();
-        other.m_head = nullptr;
-        return *this;
-    }
-    
     ~Bag()
     {