Changeset 245220 in webkit

Timestamp:

May 12, 2019 8:57:38 PM (5 years ago)

Author:

Simon Fraser

Message:

When the set of backing-sharing layers changes, we need to issue a repaint
​https://bugs.webkit.org/show_bug.cgi?id=197825

Reviewed by Zalan Bujtas.

Source/WebCore:

If the set of layers painting into a shared backing store changes, we need
to repaint that backing store. This happens when scrolling as shared layers
enter the visible area.

Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setBackingSharingLayers):

LayoutTests:

• compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
• compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html (added)
• LayoutTests/compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayerBacking.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-12  Simon Fraser  <simon.fraser@apple.com>
+
+        When the set of backing-sharing layers changes, we need to issue a repaint
+        https://bugs.webkit.org/show_bug.cgi?id=197825
+
+        Reviewed by Zalan Bujtas.
+
+        * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll-expected.html: Added.
+        * compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html: Added.
+
 2019-05-12  Takashi Komori  <Takashi.Komori@sony.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-12  Simon Fraser  <simon.fraser@apple.com>
+
+        When the set of backing-sharing layers changes, we need to issue a repaint
+        https://bugs.webkit.org/show_bug.cgi?id=197825
+
+        Reviewed by Zalan Bujtas.
+
+        If the set of layers painting into a shared backing store changes, we need
+        to repaint that backing store. This happens when scrolling as shared layers
+        enter the visible area.
+
+        Test: compositing/shared-backing/overflow-scroll/repaint-shared-on-scroll.html
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::setBackingSharingLayers):
+
 2019-05-02  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerBacking.cpp

@@ -282 +282 @@
 {
     clearBackingSharingLayerProviders(m_backingSharingLayers);
+
+    if (sharingLayers != m_backingSharingLayers)
+        setContentsNeedDisplay(); // This could be optimize to only repaint rects for changed layers.
+
     m_backingSharingLayers = WTFMove(sharingLayers);