Changeset 245312 in webkit

Timestamp:

May 14, 2019 2:49:54 PM (5 years ago)

Author:

rmorisset@apple.com

Message:

[WHLSL] parseEffectfulSuffix() is never called
​https://bugs.webkit.org/show_bug.cgi?id=195864
<rdar://problem/50746278>

Reviewed by Myles C. Maxfield.

The fix is trivial: when parseEffectfulPrefix does not see a ++ or --, it must call parseEffectfulSuffix.

No test yet, as it is not testable until the property resolver is finished.
It will be tested with the rest of the compiler, when we port the testsuite from the js implementation (it already covers this case).

• Modules/webgpu/WHLSL/WHLSLParser.cpp:

(WebCore::WHLSL::Parser::parseEffectfulPrefix):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webgpu/WHLSL/WHLSLParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-14  Robin Morisset  <rmorisset@apple.com>
+
+        [WHLSL] parseEffectfulSuffix() is never called
+        https://bugs.webkit.org/show_bug.cgi?id=195864
+        <rdar://problem/50746278>
+
+        Reviewed by Myles C. Maxfield.
+
+        The fix is trivial: when parseEffectfulPrefix does not see a ++ or --, it must call parseEffectfulSuffix.
+
+        No test yet, as it is not testable until the property resolver is finished.
+        It will be tested with the rest of the compiler, when we port the testsuite from the js implementation (it already covers this case).
+
+        * Modules/webgpu/WHLSL/WHLSLParser.cpp:
+        (WebCore::WHLSL::Parser::parseEffectfulPrefix):
+
 2019-05-14  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp

@@ -1811 +1811 @@
     auto prefix = consumeTypes({ Lexer::Token::Type::PlusPlus, Lexer::Token::Type::MinusMinus });
     if (!prefix)
-        return Unexpected<Error>(prefix.error());
+        return parseEffectfulSuffix();
 
     auto previous = parsePossiblePrefix();