Changeset 245392 in webkit

Timestamp:

May 16, 2019 2:22:22 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Updated screenHasInvertedColors to use AppKit when available
​https://bugs.webkit.org/show_bug.cgi?id=197935
<rdar://problem/50834405>

Patch by Greg Hughes <​ghughes@apple.com> on 2019-05-16
Reviewed by Chris Fleizach.

• platform/mac/PlatformScreenMac.mm:

(WebCore::collectScreenProperties):
(WebCore::screenHasInvertedColors):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/PlatformScreenMac.mm (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-16  Greg Hughes  <ghughes@apple.com>
+
+        Updated screenHasInvertedColors to use AppKit when available
+        https://bugs.webkit.org/show_bug.cgi?id=197935
+        <rdar://problem/50834405>
+
+        Reviewed by Chris Fleizach.
+
+        * platform/mac/PlatformScreenMac.mm:
+        (WebCore::collectScreenProperties):
+        (WebCore::screenHasInvertedColors):
+
 2019-05-15  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/mac/PlatformScreenMac.mm

@@ -113 +113 @@
 
     ScreenProperties screenProperties;
+    bool screenHasInvertedColors = [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors];
 
     for (NSScreen *screen in [NSScreen screens]) {
@@ -125 +126 @@
         int screenDepthPerComponent = NSBitsPerSampleFromDepth(screen.depth);
         bool screenSupportsExtendedColor = [screen canRepresentDisplayGamut:NSDisplayGamutP3];
-        bool screenHasInvertedColors = CGDisplayUsesInvertedPolarity();
         bool screenIsMonochrome = CGDisplayUsesForceToGray();
         uint32_t displayMask = CGDisplayIDToOpenGLDisplayMask(displayID);
@@ -257 +257 @@
     // This is a system-wide accessibility setting, same on all screens.
     ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
-    return CGDisplayUsesInvertedPolarity();
+    return [[NSWorkspace sharedWorkspace] accessibilityDisplayShouldInvertColors];
 }