Changeset 245396 in webkit

Timestamp:

May 16, 2019 6:54:56 AM (5 years ago)

Author:

ajuma@chromium.org

Message:

[IntersectionObserver] Regression: No initial observation when nothing else triggers rendering
​https://bugs.webkit.org/show_bug.cgi?id=197891

Reviewed by Simon Fraser.

Source/WebCore:

Schedule a rendering update whenever a new IntersectionObserver target is added.

Test: intersection-observer/initial-observation.html

• page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::observe):

LayoutTests:

Add a test where other timers that can schedule rendering updates are disabled,
in order to verify that IntersectionObserver is scheduling rendering updates
itself.

• intersection-observer/initial-observation.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/intersection-observer/initial-observation-expected.txt (added)
• LayoutTests/intersection-observer/initial-observation.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/IntersectionObserver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-16  Ali Juma  <ajuma@chromium.org>
+
+        [IntersectionObserver] Regression: No initial observation when nothing else triggers rendering
+        https://bugs.webkit.org/show_bug.cgi?id=197891
+
+        Reviewed by Simon Fraser.
+
+        Add a test where other timers that can schedule rendering updates are disabled,
+        in order to verify that IntersectionObserver is scheduling rendering updates
+        itself.
+
+        * intersection-observer/initial-observation.html: Added.
+
 2019-05-15  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-16  Ali Juma  <ajuma@chromium.org>
+
+        [IntersectionObserver] Regression: No initial observation when nothing else triggers rendering
+        https://bugs.webkit.org/show_bug.cgi?id=197891
+
+        Reviewed by Simon Fraser.
+
+        Schedule a rendering update whenever a new IntersectionObserver target is added.
+
+        Test: intersection-observer/initial-observation.html
+
+        * page/IntersectionObserver.cpp:
+        (WebCore::IntersectionObserver::observe):
+
 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/page/IntersectionObserver.cpp

@@ -159 +159 @@
     if (!hadObservationTargets)
         document->addIntersectionObserver(*this);
+    document->scheduleRenderingUpdate();
 }