Changeset 245429 in webkit


Ignore:
Timestamp:
May 16, 2019 5:07:44 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
​https://bugs.webkit.org/show_bug.cgi?id=197764
<rdar://problem/50649689>

Patch by Greg Doolittle <​gr3g@apple.com> on 2019-05-16
Reviewed by Chris Fleizach.

Specifically these:

  • ariaActiveDescendant
  • ariaControls
  • ariaDescribedBy
  • ariaDetails
  • ariaErrorMessage
  • ariaFlowTo
  • ariaLabelledBy
  • ariaOwns

Source/WebCore:

Test: LayoutTests/accessibility/ARIA-reflections.html (updated)

  • accessibility/AriaAttributes.idl:

LayoutTests:

  • accessibility/ARIA-reflection-expected.txt: Updated.
  • accessibility/ARIA-reflection.html: Updated.
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r245427 r245429  
     12019-05-16  Greg Doolittle  <gr3g@apple.com>
     2
     3        AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
     4        https://bugs.webkit.org/show_bug.cgi?id=197764
     5        <rdar://problem/50649689>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        Specifically these:
     10        - ariaActiveDescendant
     11        - ariaControls
     12        - ariaDescribedBy
     13        - ariaDetails
     14        - ariaErrorMessage
     15        - ariaFlowTo
     16        - ariaLabelledBy
     17        - ariaOwns
     18
     19        * accessibility/ARIA-reflection-expected.txt: Updated.
     20        * accessibility/ARIA-reflection.html: Updated.
     21
    1222019-05-16  John Wilander  <wilander@apple.com>
    223

  • trunk/LayoutTests/accessibility/ARIA-reflection-expected.txt

    r234482 r245429  
    1313PASS element[currentProperty] is otherData
    1414
    15 Test ariaActiveDescendant < - > aria-activedescendant
    16 PASS element[currentProperty] is null
    17 PASS element.getAttribute(currentAttribute) is null
    18 element["ariaActiveDescendant"] = data;
    19 PASS element.getAttribute(currentAttribute) is data
    20 element.setAttribute("aria-activedescendant", otherData);
    21 PASS element[currentProperty] is otherData
    22 
    2315Test ariaAtomic < - > aria-atomic
    2416PASS element[currentProperty] is null
    … …  
    7769PASS element[currentProperty] is otherData
    7870
    79 Test ariaControls < - > aria-controls
    80 PASS element[currentProperty] is null
    81 PASS element.getAttribute(currentAttribute) is null
    82 element["ariaControls"] = data;
    83 PASS element.getAttribute(currentAttribute) is data
    84 element.setAttribute("aria-controls", otherData);
    85 PASS element[currentProperty] is otherData
    86 
    8771Test ariaCurrent < - > aria-current
    8872PASS element[currentProperty] is null
    … …  
    9377PASS element[currentProperty] is otherData
    9478
    95 Test ariaDescribedBy < - > aria-describedby
    96 PASS element[currentProperty] is null
    97 PASS element.getAttribute(currentAttribute) is null
    98 element["ariaDescribedBy"] = data;
    99 PASS element.getAttribute(currentAttribute) is data
    100 element.setAttribute("aria-describedby", otherData);
    101 PASS element[currentProperty] is otherData
    102 
    103 Test ariaDetails < - > aria-details
    104 PASS element[currentProperty] is null
    105 PASS element.getAttribute(currentAttribute) is null
    106 element["ariaDetails"] = data;
    107 PASS element.getAttribute(currentAttribute) is data
    108 element.setAttribute("aria-details", otherData);
    109 PASS element[currentProperty] is otherData
    110 
    11179Test ariaDisabled < - > aria-disabled
    11280PASS element[currentProperty] is null
    … …  
    11785PASS element[currentProperty] is otherData
    11886
    119 Test ariaErrorMessage < - > aria-errormessage
    120 PASS element[currentProperty] is null
    121 PASS element.getAttribute(currentAttribute) is null
    122 element["ariaErrorMessage"] = data;
    123 PASS element.getAttribute(currentAttribute) is data
    124 element.setAttribute("aria-errormessage", otherData);
    125 PASS element[currentProperty] is otherData
    126 
    12787Test ariaExpanded < - > aria-expanded
    12888PASS element[currentProperty] is null
    … …  
    13393PASS element[currentProperty] is otherData
    13494
    135 Test ariaFlowTo < - > aria-flowto
    136 PASS element[currentProperty] is null
    137 PASS element.getAttribute(currentAttribute) is null
    138 element["ariaFlowTo"] = data;
    139 PASS element.getAttribute(currentAttribute) is data
    140 element.setAttribute("aria-flowto", otherData);
    141 PASS element[currentProperty] is otherData
    142 
    14395Test ariaHasPopup < - > aria-haspopup
    14496PASS element[currentProperty] is null
    … …  
    181133PASS element[currentProperty] is otherData
    182134
    183 Test ariaLabelledBy < - > aria-labelledby
    184 PASS element[currentProperty] is null
    185 PASS element.getAttribute(currentAttribute) is null
    186 element["ariaLabelledBy"] = data;
    187 PASS element.getAttribute(currentAttribute) is data
    188 element.setAttribute("aria-labelledby", otherData);
    189 PASS element[currentProperty] is otherData
    190 
    191135Test ariaLevel < - > aria-level
    192136PASS element[currentProperty] is null
    … …  
    237181PASS element[currentProperty] is otherData
    238182
    239 Test ariaOwns < - > aria-owns
    240 PASS element[currentProperty] is null
    241 PASS element.getAttribute(currentAttribute) is null
    242 element["ariaOwns"] = data;
    243 PASS element.getAttribute(currentAttribute) is data
    244 element.setAttribute("aria-owns", otherData);
    245 PASS element[currentProperty] is otherData
    246 
    247183Test ariaPlaceholder < - > aria-placeholder
    248184PASS element[currentProperty] is null
    … …  
    382318
    383319
    384 PASS count is 46
     320PASS count is 38
    385321PASS successfullyParsed is true
    386322

  • trunk/LayoutTests/accessibility/ARIA-reflection.html

    r234482 r245429  
    6060
    6161        debug("\n");
    62         shouldBe("count", "46");
     62        shouldBe("count", "38");
    6363
    6464    } else {

  • trunk/Source/WebCore/ChangeLog

    r245407 r245429  
     12019-05-16  Greg Doolittle  <gr3g@apple.com>
     2
     3        AX: Unship some ARIA string reflectors that are to-be-replaced by element reflection
     4        https://bugs.webkit.org/show_bug.cgi?id=197764
     5        <rdar://problem/50649689>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        Specifically these:
     10        - ariaActiveDescendant
     11        - ariaControls
     12        - ariaDescribedBy
     13        - ariaDetails
     14        - ariaErrorMessage
     15        - ariaFlowTo
     16        - ariaLabelledBy
     17        - ariaOwns
     18
     19        Test: LayoutTests/accessibility/ARIA-reflections.html (updated)
     20
     21        * accessibility/AriaAttributes.idl:
     22
    1232019-05-16  Youenn Fablet  <youenn@apple.com>
    224

  • trunk/Source/WebCore/accessibility/AriaAttributes.idl

    r234482 r245429  
    2828    NoInterfaceObject,
    2929] interface AriaAttributes {
    30     [Reflect=aria_activedescendant] attribute DOMString? ariaActiveDescendant;
    3130    [Reflect=aria_atomic]           attribute DOMString? ariaAtomic;
    3231    [Reflect=aria_autocomplete]     attribute DOMString? ariaAutoComplete;
    … …  
    3635    [Reflect=aria_colindex]         attribute DOMString? ariaColIndex;
    3736    [Reflect=aria_colspan]          attribute DOMString? ariaColSpan;
    38     [Reflect=aria_controls]         attribute DOMString? ariaControls;
    3937    [Reflect=aria_current]          attribute DOMString? ariaCurrent;
    40     [Reflect=aria_describedby]      attribute DOMString? ariaDescribedBy;
    41     [Reflect=aria_details]          attribute DOMString? ariaDetails;
    4238    [Reflect=aria_disabled]         attribute DOMString? ariaDisabled;
    43     [Reflect=aria_errormessage]     attribute DOMString? ariaErrorMessage;
    4439    [Reflect=aria_expanded]         attribute DOMString? ariaExpanded;
    45     [Reflect=aria_flowto]           attribute DOMString? ariaFlowTo;
    4640    [Reflect=aria_haspopup]         attribute DOMString? ariaHasPopup;
    4741    [Reflect=aria_hidden]           attribute DOMString? ariaHidden;
    … …  
    4943    [Reflect=aria_keyshortcuts]     attribute DOMString? ariaKeyShortcuts;
    5044    [Reflect=aria_label]            attribute DOMString? ariaLabel;
    51     [Reflect=aria_labelledby]       attribute DOMString? ariaLabelledBy;
    5245    [Reflect=aria_level]            attribute DOMString? ariaLevel;
    5346    [Reflect=aria_live]             attribute DOMString? ariaLive;
    … …  
    5649    [Reflect=aria_multiselectable]  attribute DOMString? ariaMultiSelectable;
    5750    [Reflect=aria_orientation]      attribute DOMString? ariaOrientation;
    58     [Reflect=aria_owns]             attribute DOMString? ariaOwns;
    5951    [Reflect=aria_placeholder]      attribute DOMString? ariaPlaceholder;
    6052    [Reflect=aria_posinset]         attribute DOMString? ariaPosInSet;
Note: See TracChangeset for help on using the changeset viewer.