Changeset 245430 in webkit

Timestamp:

May 16, 2019 6:17:47 PM (5 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r15133): Fix leak of JSStringRef in minidom
<​https://webkit.org/b/197968>
<rdar://problem/50872430>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• API/tests/minidom.c:

(print): Call JSStringRelease() to fix the leak.

Tools:

• TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:

(expectScriptValueIsString): Drive-by fix to use adopt() instead
of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).

Location:

trunk

Files:

• Source/JavaScriptCore/API/tests/minidom.c (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm (modified) (1 diff)

trunk/Source/JavaScriptCore/API/tests/minidom.c

@@ -92 +92 @@
         JSStringGetUTF8CString(string, stringUTF8, numChars);
         printf("%s\n", stringUTF8);
+        JSStringRelease(string);
     }
     

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-05-16  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r15133): Fix leak of JSStringRef in minidom
+        <https://webkit.org/b/197968>
+        <rdar://problem/50872430>
+
+        Reviewed by Joseph Pecoraro.
+
+        * API/tests/minidom.c:
+        (print): Call JSStringRelease() to fix the leak.
+
 2019-05-16  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-05-16  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r15133): Fix leak of JSStringRef in minidom
+        <https://webkit.org/b/197968>
+        <rdar://problem/50872430>
+
+        Reviewed by Joseph Pecoraro.
+
+        * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
+        (expectScriptValueIsString): Drive-by fix to use adopt() instead
+        of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
+
 2019-05-16  David Kilzer  <ddkilzer@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm

@@ -78 +78 @@
     EXPECT_TRUE(JSValueIsString(scriptContext, scriptValue));
     
-    JSRetainPtr<JSStringRef> scriptString(Adopt, JSValueToStringCopy(scriptContext, scriptValue, 0));
+    auto scriptString = adopt(JSValueToStringCopy(scriptContext, scriptValue, 0));
     EXPECT_TRUE(JSStringIsEqualToUTF8CString(scriptString.get(), expectedValue));