Changeset 245518 in webkit


Ignore:
Timestamp:
May 20, 2019 10:24:20 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Hitpoint for link which spans two lines in web content is incorrect
https://bugs.webkit.org/show_bug.cgi?id=197511
<rdar://problem/49971483>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-05-20
Reviewed by Chris Fleizach.

  • accessibility/ios-simulator/links-activation.html:
  • accessibility/links-activation-expected.txt:
  • accessibility/links-activation.html:
Location:
trunk/LayoutTests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r245517 r245518  
     12019-05-20  Andres Gonzalez  <andresg_22@apple.com>
     2
     3        Hitpoint for link which spans two lines in web content is incorrect
     4        https://bugs.webkit.org/show_bug.cgi?id=197511
     5        <rdar://problem/49971483>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        * accessibility/ios-simulator/links-activation.html:
     10        * accessibility/links-activation-expected.txt:
     11        * accessibility/links-activation.html:
     12
    1132019-05-20  Sihui Liu  <sihui_liu@apple.com>
    214
  • trunk/LayoutTests/accessibility/ios-simulator/links-activation.html

    r244983 r245518  
    3838
    3939    if (window.accessibilityController) {
    40         window.jsTestIsAsync = true;
    41 
    4240        var link = accessibilityController.accessibleElementById("multiline-link");
    4341        shouldBeTrue("clickPointInsideFrame(link)");
     
    4745        shouldBeTrue("clickPointInsideFrame(link)");
    4846        link.press();
    49 
    50         setTimeout(
    51             function() {
    52                 finishJSTest();
    53             }, 10);
    5447    }
    5548</script>
  • trunk/LayoutTests/accessibility/links-activation-expected.txt

    r244983 r245518  
    1313
    1414click event [object MouseEvent] for element A with id multiline-link
     15PASS clicked became true
    1516click event [object MouseEvent] for element A with id singleline-link
     17PASS clicked became true
    1618PASS successfullyParsed is true
    1719
  • trunk/LayoutTests/accessibility/links-activation.html

    r244983 r245518  
    77    testRunner.dumpAsText();
    88
     9var clicked = false;
    910function handleClick(event) {
     11    clicked = true;
    1012    debug("click event " + event
    1113          + " for element " + event.target.nodeName
     
    3638        var link = accessibilityController.accessibleElementById("multiline-link");
    3739        link.press();
     40        shouldBecomeEqual("clicked", "true", function() {
     41            clicked = false;
    3842
    39         link = accessibilityController.accessibleElementById("singleline-link");
    40         link.press();
    41 
    42         setTimeout(
    43             function() {
     43            link = accessibilityController.accessibleElementById("singleline-link");
     44            link.press();
     45            shouldBecomeEqual("clicked", "true", function() {
    4446                finishJSTest();
    45             }, 10);
     47            });
     48        });
    4649    }
    4750</script>
Note: See TracChangeset for help on using the changeset viewer.