Changeset 245651 in webkit


Ignore:
Timestamp:
May 22, 2019 3:08:25 PM (5 years ago)
Author:
Simon Fraser
Message:

Inner scroller of nested overflow:scrolls jitters when scrolling
https://bugs.webkit.org/show_bug.cgi?id=198131

Reviewed by Antti Koivisto.

Source/WebCore:

enclosingCompositedScrollingLayer(layer) would return the layer itself, rather than
its scrolling ancestor, which meant that a composited scroller nested inside another
scroller would fail to get a "Moves" scrolling tree node, and therefore jitter
when scrolling.

Test: scrollingcoordinator/scrolling-tree/nested-overflow-scroll.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::enclosingCompositedScrollingLayer):

LayoutTests:

  • fast/scrolling/ios/overflow-scroll-overlap-6-expected.txt: Progression
  • platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt: Added.
  • scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt: Added.
  • scrollingcoordinator/scrolling-tree/nested-overflow-scroll.html: Added.
Location:
trunk
Files:
3 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r245647 r245651  
     12019-05-22  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Inner scroller of nested overflow:scrolls jitters when scrolling
     4        https://bugs.webkit.org/show_bug.cgi?id=198131
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * fast/scrolling/ios/overflow-scroll-overlap-6-expected.txt: Progression
     9        * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt: Added.
     10        * scrollingcoordinator/scrolling-tree/nested-overflow-scroll-expected.txt: Added.
     11        * scrollingcoordinator/scrolling-tree/nested-overflow-scroll.html: Added.
     12
    1132019-05-22  Ryan Haddad  <ryanhaddad@apple.com>
    214
  • trunk/LayoutTests/fast/scrolling/ios/overflow-scroll-overlap-6-expected.txt

    r244215 r245651  
    33case 1:
    44case 2:
    5 case 3:
     5case 3: Scrollable 3
    66
  • trunk/Source/WebCore/ChangeLog

    r245647 r245651  
     12019-05-22  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Inner scroller of nested overflow:scrolls jitters when scrolling
     4        https://bugs.webkit.org/show_bug.cgi?id=198131
     5
     6        Reviewed by Antti Koivisto.
     7
     8        enclosingCompositedScrollingLayer(layer) would return the layer itself, rather than
     9        its scrolling ancestor, which meant that a composited scroller nested inside another
     10        scroller would fail to get a "Moves" scrolling tree node, and therefore jitter
     11        when scrolling.
     12
     13        Test: scrollingcoordinator/scrolling-tree/nested-overflow-scroll.html
     14
     15        * rendering/RenderLayerCompositor.cpp:
     16        (WebCore::enclosingCompositedScrollingLayer):
     17
    1182019-05-22  Ryan Haddad  <ryanhaddad@apple.com>
    219
  • trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

    r245602 r245651  
    30273027static RenderLayer* enclosingCompositedScrollingLayer(const RenderLayer& layer, const RenderLayer& intermediateLayer, bool& sawIntermediateLayer)
    30283028{
    3029     const auto* currLayer = &layer;
     3029    const auto* currLayer = layer.parent();
    30303030    while (currLayer) {
    30313031        if (currLayer == &intermediateLayer)
Note: See TracChangeset for help on using the changeset viewer.