Changeset 245771 in webkit

Timestamp:

May 25, 2019 8:01:09 AM (5 years ago)

Author:

Simon Fraser

Message:

[macOS] Fix programmatic scroll in RTL overflow with async scrolling enabled
​https://bugs.webkit.org/show_bug.cgi?id=198226

Reviewed by Antti Koivisto.

Source/WebCore:

On macOS we need to use a scroll offset to set the layer position, not
a scroll position.

Test: scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html

• page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::repositionScrollingLayers):

Source/WebCore/../../LayoutTests:

• scrollingcoordinator/mac/rtl-programmatic-overflow-scroll-expected.html: Added.
• scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/scrollingcoordinator/mac/rtl-programmatic-overflow-scroll-expected.html (added)
• LayoutTests/scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-05-25  Simon Fraser  <simon.fraser@apple.com>
+
+        [macOS] Fix programmatic scroll in RTL overflow with async scrolling enabled
+        https://bugs.webkit.org/show_bug.cgi?id=198226
+
+        Reviewed by Antti Koivisto.
+
+        * scrollingcoordinator/mac/rtl-programmatic-overflow-scroll-expected.html: Added.
+        * scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html: Added.
+
 2019-05-24  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-25  Simon Fraser  <simon.fraser@apple.com>
+
+        [macOS] Fix programmatic scroll in RTL overflow with async scrolling enabled
+        https://bugs.webkit.org/show_bug.cgi?id=198226
+
+        Reviewed by Antti Koivisto.
+
+        On macOS we need to use a scroll offset to set the layer position, not
+        a scroll position.
+
+        Test: scrollingcoordinator/mac/rtl-programmatic-overflow-scroll.html
+
+        * page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:
+        (WebCore::ScrollingTreeOverflowScrollingNodeMac::repositionScrollingLayers):
+
 2019-05-24  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WebCore/page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm

@@ -91 +91 @@
 void ScrollingTreeOverflowScrollingNodeMac::repositionScrollingLayers()
 {
-    auto scrollPosition = currentScrollPosition();
-    scrolledContentsLayer().position = -scrollPosition;
+    auto scrollOffset = ScrollableArea::scrollOffsetFromPosition(currentScrollPosition(), toFloatSize(scrollOrigin()));
+    scrolledContentsLayer().position = -scrollOffset;
 }