Changeset 24597 in webkit

Timestamp:

Jul 24, 2007 11:47:55 AM (17 years ago)

Author:

yongjzha

Message:

2007-07-20 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.

​http://bugs.webkit.org/show_bug.cgi?id=14688

• khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):

Location:

S60/trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• khtml/html/html_miscimpl.cpp (modified) (1 diff)

S60/trunk/WebCore/ChangeLog

@@ +1 @@
+2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>
+        Reviewed by Yongjun
+        DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
+        Fix - Remove Nokia specific changes so that the name chache is updated before 
+              an attempt to retrieve information from it.               
+        
+        http://bugs.webkit.org/show_bug.cgi?id=14688
+        * khtml/html/html_miscimpl.cpp:
+        (HTMLCollectionImpl::namedItems):
+
 raalexan, reviewed by Zalan
  DESC: AJPA-74XD84 Some input format doesn't work properly.

S60/trunk/WebCore/khtml/html/html_miscimpl.cpp

@@ -394 +394 @@
         return result;
 
-#if NOKIA_CHANGES
-        // optimisation: first find if there are some nodes already in the cache 
-        // - this might cause some abnormal behaviors, but could achieve better
-        // performance because updateNameCache() is extremely slow for big collections.
-        // (e.g., the hugh form of www.finnair.fi).
-        if( info )
-        {
-                QPtrVector<NodeImpl>* ids = info->idCache.find(name.string());
-                QPtrVector<NodeImpl>* names = info->nameCache.find(name.string());
-                
-                for (unsigned i = 0; ids && i < ids->count(); ++i) {
-                        result.append(ids->at(i));
-                }
-
-                for (unsigned i = 0; names && i < names->count(); ++i) {
-                        result.append(names->at(i));
-                }
-
-                if( !result.isEmpty() ) return result;
-        }
-#endif
-
     resetCollectionInfo();
     updateNameCache();