Changeset 24598 in webkit


Ignore:
Timestamp:
Jul 24, 2007 11:49:22 AM (17 years ago)
Author:
yongjzha
Message:

2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before

an attempt to retrieve information from it.


http://bugs.webkit.org/show_bug.cgi?id=14688

  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
Location:
S60/branches/3.1m/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • S60/branches/3.1m/WebCore/ChangeLog

    r24110 r24598  
     12007-07-20 vmalaiya, <vikram.malaiya@nokia.com>
     2        Reviewed by Yongjun
     3        DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
     4        Fix - Remove Nokia specific changes so that the name chache is updated before
     5              an attempt to retrieve information from it.               
     6       
     7        http://bugs.webkit.org/show_bug.cgi?id=14688
     8        * khtml/html/html_miscimpl.cpp:
     9        (HTMLCollectionImpl::namedItems):
     10
    1112007-06-29  bujtas  <zbujtas@gmail.com>
    212
  • S60/branches/3.1m/WebCore/khtml/html/html_miscimpl.cpp

    r14549 r24598  
    394394        return result;
    395395
    396 #if NOKIA_CHANGES
    397         // optimisation: first find if there are some nodes already in the cache
    398         // - this might cause some abnormal behaviors, but could achieve better
    399         // performance because updateNameCache() is extremely slow for big collections.
    400         // (e.g., the hugh form of www.finnair.fi).
    401         if( info )
    402         {
    403                 QPtrVector<NodeImpl>* ids = info->idCache.find(name.string());
    404                 QPtrVector<NodeImpl>* names = info->nameCache.find(name.string());
    405                
    406                 for (unsigned i = 0; ids && i < ids->count(); ++i) {
    407                         result.append(ids->at(i));
    408                 }
    409 
    410                 for (unsigned i = 0; names && i < names->count(); ++i) {
    411                         result.append(names->at(i));
    412                 }
    413 
    414                 if( !result.isEmpty() ) return result;
    415         }
    416 #endif
    417 
    418396    resetCollectionInfo();
    419397    updateNameCache();
Note: See TracChangeset for help on using the changeset viewer.