Changeset 245980 in webkit

Timestamp:

May 31, 2019 1:23:31 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Inserting a newline in contenteditable causes two characters to be added instead of one
​https://bugs.webkit.org/show_bug.cgi?id=197894
<rdar://problems/49700998>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-05-31
Reviewed by Chris Fleizach.

No new test is necessary since this is a comment change.

Removed radar reference from code.

• editing/Editing.cpp:

(WebCore::visiblePositionForIndexUsingCharacterIterator):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/Editing.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-05-31  Andres Gonzalez  <andresg_22@apple.com>
+
+        Inserting a newline in contenteditable causes two characters to be added instead of one
+        https://bugs.webkit.org/show_bug.cgi?id=197894
+        <rdar://problems/49700998>
+
+        Reviewed by Chris Fleizach.
+
+        No new test is necessary since this is a comment change.
+
+        Removed radar reference from code.
+
+        * editing/Editing.cpp:
+        (WebCore::visiblePositionForIndexUsingCharacterIterator):
+
 2019-05-31  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/editing/Editing.cpp

@@ -1124 +1124 @@
 
     if (!it.atEnd() && it.text()[0] == '\n') {
-        // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines (see rdar://5192593)
+        // FIXME: workaround for collapsed range (where only start position is correct) emitted for some emitted newlines.
         auto range = it.range();
         if (range->startPosition() == range->endPosition()) {