Changeset 245994 in webkit


Ignore:
Timestamp:
May 31, 2019, 4:20:14 PM (7 years ago)
Author:
Simon Fraser
Message:

[Mac WK2 Debug] Layout Test scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=197425

Unreviewed test gardening.

Speculative fix for flakey test; trigger layout inside the subframe.

  • scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r245993 r245994  
    1 2019-05-31  Ryosuke Niwa  <rniwa@webkit.org>
    2 
    3         [iOS] Reveal the focused element when it's immediately above software keyboard
    4         https://bugs.webkit.org/show_bug.cgi?id=198412
    5 
    6         Reviewed by Wenson Hsieh.
    7 
    8         Added a regression test. Note that this test always passes on non-iPad platforms either
    9         before or after this patch as _zoomToRevealFocusedElement forces scrolling in that case.
    10 
    11         * fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad-expected.txt: Added.
    12         * fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad.html: Added.
    13 
    1412019-05-31  Nikita Vasilyev  <nvasilyev@apple.com>
    152
    … …  
    2411        * inspector/unit-tests/array-utilities-expected.txt:
    2512        * inspector/unit-tests/array-utilities.html:
     13
     142019-05-31  Ryosuke Niwa  <rniwa@webkit.org>
     15
     16        [iOS] Reveal the focused element when it's immediately above software keyboard
     17        https://bugs.webkit.org/show_bug.cgi?id=198412
     18
     19        Reviewed by Wenson Hsieh.
     20
     21        Added a regression test. Note that this test always passes on non-iPad platforms either
     22        before or after this patch as _zoomToRevealFocusedElement forces scrolling in that case.
     23
     24        * fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad-expected.txt: Added.
     25        * fast/scrolling/ios/reveal-focused-element-right-above-keyboard-on-ipad.html: Added.
     26
     272019-05-31  Simon Fraser  <simon.fraser@apple.com>
     28
     29        [Mac WK2 Debug] Layout Test scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html is a flaky failure
     30        https://bugs.webkit.org/show_bug.cgi?id=197425
     31
     32        Unreviewed test gardening.
     33       
     34        Speculative fix for flakey test; trigger layout inside the subframe.
     35
     36        * scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html:
    2637
    27382019-05-31  Ryosuke Niwa  <rniwa@webkit.org>

  • trunk/LayoutTests/scrollingcoordinator/scrolling-tree/scrolling-tree-includes-frame.html

    r240505 r245994  
    1212      function doTest()
    1313      {
    14           if (window.internals)
    15               document.getElementById('scrollingTree').innerText = window.internals.scrollingStateTreeAsText() + "\n";
     14          if (window.internals) {
     15                          subframe.contentWindow.internals.scrollingStateTreeAsText(); // Trigger frame layout.
     16              document.getElementById('scrollingTree').innerText = internals.scrollingStateTreeAsText() + "\n";
     17          }
     18
    1619          if (window.testRunner)
    1720              testRunner.notifyDone();
    … …  
    3235  </head>
    3336  <body>
    34     <iframe onload="doTest()" srcdoc="
     37    <iframe id="subframe" onload="doTest()" srcdoc="
    3538        <div style='width: 300px; height: 400px; background: gray;'></div>">
    3639    </iframe>
Note: See TracChangeset for help on using the changeset viewer.