Changeset 246087 in webkit
- Timestamp:
- Jun 4, 2019 4:31:34 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r246083 r246087 1 2019-06-04 Chris Dumez <cdumez@apple.com> 2 3 Crash when calling XMLHttpRequest.setRequestHeader() in a worker 4 https://bugs.webkit.org/show_bug.cgi?id=198534 5 <rdar://problem/51393912> 6 7 Reviewed by Alex Christensen. 8 9 Add layout test coverage. 10 11 * fast/workers/resources/worker-xhr-setRequestHeader.js: Added. 12 * fast/workers/worker-xhr-setRequestHeader-expected.txt: Added. 13 * fast/workers/worker-xhr-setRequestHeader.html: Added. 14 1 15 2019-06-04 Antti Koivisto <antti@apple.com> 2 16 -
trunk/Source/WebCore/ChangeLog
r246083 r246087 1 2019-06-04 Chris Dumez <cdumez@apple.com> 2 3 Crash when calling XMLHttpRequest.setRequestHeader() in a worker 4 https://bugs.webkit.org/show_bug.cgi?id=198534 5 <rdar://problem/51393912> 6 7 Reviewed by Alex Christensen. 8 9 Make sure the script execution context is a Document because calling document() 10 to get the settings. 11 12 Test: fast/workers/worker-xhr-setRequestHeader.html 13 14 * xml/XMLHttpRequest.cpp: 15 (WebCore::XMLHttpRequest::setRequestHeader): 16 1 17 2019-06-04 Antti Koivisto <antti@apple.com> 2 18 -
trunk/Source/WebCore/xml/XMLHttpRequest.cpp
r244823 r246087 818 818 allowUnsafeHeaderField = usesDashboardBackwardCompatibilityMode(); 819 819 #endif 820 if (securityOrigin()->canLoadLocalResources() && document()->settings().allowSettingAnyXHRHeaderFromFileURLs()) 820 821 // FIXME: The allowSettingAnyXHRHeaderFromFileURLs setting currently only applies to Documents, not workers. 822 if (securityOrigin()->canLoadLocalResources() && scriptExecutionContext()->isDocument() && document()->settings().allowSettingAnyXHRHeaderFromFileURLs()) 821 823 allowUnsafeHeaderField = true; 822 824 if (!allowUnsafeHeaderField && isForbiddenHeaderName(name)) {
Note: See TracChangeset
for help on using the changeset viewer.