Changeset 246151 in webkit

Timestamp:

Jun 6, 2019 6:41:21 AM (5 years ago)

Author:

Michael Catanzaro

Message:

aarch64: ‘JSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegister’ is too small to hold all values of ‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’}
​https://bugs.webkit.org/show_bug.cgi?id=198014

Reviewed by Yusuke Suzuki.

When building for aarch64, there is a huge warning spam here. It's impossible to see any
other warnings. This has been ongoing for so long I've begun to suspect that nobody works
on this architecture.

Anyway, the problem is because we need eight bits to store all possible RegisterID values,
but the bitfield is only six bits wide. Fix it. The COMPILE_ASSERT checking the size of this
struct is still happy, so I presume the change is OK.

• assembler/ARM64Assembler.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• assembler/ARM64Assembler.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-06-06  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        aarch64: ‘JSC::ARM64Assembler::LinkRecord::<unnamed union>::RealTypes::m_compareRegister’ is too small to hold all values of ‘JSC::ARM64Assembler::RegisterID’ {aka ‘enum JSC::ARM64Registers::RegisterID’}
+        https://bugs.webkit.org/show_bug.cgi?id=198014
+
+        Reviewed by Yusuke Suzuki.
+
+        When building for aarch64, there is a huge warning spam here. It's impossible to see any
+        other warnings. This has been ongoing for so long I've begun to suspect that nobody works
+        on this architecture.
+
+        Anyway, the problem is because we need eight bits to store all possible RegisterID values,
+        but the bitfield is only six bits wide. Fix it. The COMPILE_ASSERT checking the size of this
+        struct is still happy, so I presume the change is OK.
+
+        * assembler/ARM64Assembler.h:
+
 2019-06-06  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/assembler/ARM64Assembler.h

@@ -459 +459 @@
                 int64_t m_from;
                 int64_t m_to;
+                RegisterID m_compareRegister;
                 JumpType m_type : 8;
                 JumpLinkType m_linkType : 8;
                 Condition m_condition : 4;
                 unsigned m_bitNumber : 6;
-                RegisterID m_compareRegister : 6;
                 bool m_is64Bit : 1;
             } realTypes;