Changeset 246183 in webkit


Ignore:
Timestamp:
Jun 6, 2019 5:30:09 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r246165.
​https://bugs.webkit.org/show_bug.cgi?id=198636

Causing test failures in 7 content-observation tests.
(Requested by ShawnRoberts on #webkit).

Reverted changeset:

"Restrict fast clicks everywhere to desktop content mode"
​https://bugs.webkit.org/show_bug.cgi?id=198610
​https://trac.webkit.org/changeset/246165

Location:
trunk
Files:
2 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r246178 r246183  
     12019-06-06  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r246165.
     4        https://bugs.webkit.org/show_bug.cgi?id=198636
     5
     6        Causing test failures in 7 content-observation tests.
     7        (Requested by ShawnRoberts on #webkit).
     8
     9        Reverted changeset:
     10
     11        "Restrict fast clicks everywhere to desktop content mode"
     12        https://bugs.webkit.org/show_bug.cgi?id=198610
     13        https://trac.webkit.org/changeset/246165
     14
    1152019-06-06  Devin Rousso  <drousso@apple.com>
    216

  • trunk/Source/WebKit/ChangeLog

    r246181 r246183  
     12019-06-06  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r246165.
     4        https://bugs.webkit.org/show_bug.cgi?id=198636
     5
     6        Causing test failures in 7 content-observation tests.
     7        (Requested by ShawnRoberts on #webkit).
     8
     9        Reverted changeset:
     10
     11        "Restrict fast clicks everywhere to desktop content mode"
     12        https://bugs.webkit.org/show_bug.cgi?id=198610
     13        https://trac.webkit.org/changeset/246165
     14
    1152019-06-06  Commit Queue  <commit-queue@webkit.org>
    216

  • trunk/Source/WebKit/UIProcess/WebPageProxy.h

    r246165 r246183  
    519519    bool hasCommittedAnyProvisionalLoads() const { return m_hasCommittedAnyProvisionalLoads; }
    520520
    521     bool allowsFastClicksEverywhere() const { return m_allowsFastClicksEverywhere; }
    522 
    523521    void setIsUsingHighPerformanceWebGL(bool value) { m_isUsingHighPerformanceWebGL = value; }
    524522    bool isUsingHighPerformanceWebGL() const { return m_isUsingHighPerformanceWebGL; }
    … …  
    24812479    bool m_openedByDOM { false };
    24822480    bool m_hasCommittedAnyProvisionalLoads { false };
    2483     bool m_allowsFastClicksEverywhere { false };
    24842481
    24852482    HashMap<String, Ref<WebURLSchemeHandler>> m_urlSchemeHandlersByScheme;

  • trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

    r246165 r246183  
    15881588        return;
    15891589
    1590     if (_page->preferences().fastClicksEverywhere() && _page->allowsFastClicksEverywhere()) {
     1590    if (_page->preferences().fastClicksEverywhere()) {
    15911591        RELEASE_LOG(ViewGestures, "Potential tap found an element and fast taps are forced on. Trigger click. (%p)", self);
    15921592        [self _setDoubleTapGesturesEnabled:NO];

  • trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

    r246165 r246183  
    13771377    }
    13781378
    1379     m_allowsFastClicksEverywhere = false;
    1380 
    13811379    if (!useDesktopBrowsingMode)
    13821380        return WebContentMode::Mobile;
    … …  
    14001398        policies.setSimulatedMouseEventsDispatchPolicy(WebsiteSimulatedMouseEventsDispatchPolicy::Allow);
    14011399        policies.setLegacyOverflowScrollingTouchPolicy(WebsiteLegacyOverflowScrollingTouchPolicy::Disable);
    1402         m_allowsFastClicksEverywhere = true;
    14031400    }
    14041401
Note: See TracChangeset for help on using the changeset viewer.