Changeset 246192 in webkit

Timestamp:

Jun 7, 2019 1:14:03 AM (5 years ago)

Author:

Philippe Normand

Message:

[GStreamer] videorate issues with v4l2src
​https://bugs.webkit.org/show_bug.cgi?id=198614

Reviewed by Xabier Rodriguez-Calvar.

Configure videorate to cope with the live stream provided by the
source element. Not doing so might lead to errors in the v4l2
buffer allocator.

• platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:

(WebCore::GStreamerVideoCapturer::createConverter):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-07  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] videorate issues with v4l2src
+        https://bugs.webkit.org/show_bug.cgi?id=198614
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Configure videorate to cope with the live stream provided by the
+        source element. Not doing so might lead to errors in the v4l2
+        buffer allocator.
+
+        * platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
+        (WebCore::GStreamerVideoCapturer::createConverter):
+
 2019-06-06  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp

@@ -39 +39 @@
 GstElement* GStreamerVideoCapturer::createConverter()
 {
-    auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate", TRUE, nullptr);
-
+    // https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/97#note_56575
+    auto converter = gst_parse_bin_from_description("videoscale ! videoconvert ! videorate drop-only=1 average-period=1", TRUE, nullptr);
     ASSERT(converter);