Changeset 246198 in webkit

Timestamp:

Jun 7, 2019 7:42:56 AM (5 years ago)

Author:

Wenson Hsieh

Message:

[iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
​https://bugs.webkit.org/show_bug.cgi?id=198641
<rdar://problem/51266310>

Reviewed by Tim Horton.

Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
_UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
reproduces on iOS simulator.

To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
representation is actually ignored by most clients anyways (including WebKit), in favor of using
"com.apple.flat-rtfd".

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestWKWebView.mm:

(applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
(-[TestWKWebView initWithFrame:configuration:addToWindow:]):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm (modified) (3 diffs)
• TestWebKitAPI/cocoa/TestWKWebView.mm (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
+        https://bugs.webkit.org/show_bug.cgi?id=198641
+        <rdar://problem/51266310>
+
+        Reviewed by Tim Horton.
+
+        Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
+        UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
+        representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
+        _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
+        append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
+        reproduces on iOS simulator.
+
+        To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
+        representation is actually ignored by most clients anyways (including WebKit), in favor of using
+        "com.apple.flat-rtfd".
+
+        * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/cocoa/TestWKWebView.mm:
+        (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
+        (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
+
 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm

@@ -1011 +1011 @@
 TEST(WKAttachmentTests, InsertPastedAttributedStringContainingImage)
 {
+    auto webView = webViewForTestingAttachments();
     platformCopyRichTextWithImage();
 
     RetainPtr<_WKAttachment> attachment;
-    auto webView = webViewForTestingAttachments();
     {
         ObserveAttachmentUpdatesForScope observer(webView.get());
@@ -1037 +1037 @@
 TEST(WKAttachmentTests, InsertPastedAttributedStringContainingMultipleAttachments)
 {
+    auto webView = webViewForTestingAttachments();
     platformCopyRichTextWithMultipleAttachments();
 
@@ -1042 +1043 @@
     RetainPtr<_WKAttachment> zipAttachment;
     RetainPtr<_WKAttachment> pdfAttachment;
-    auto webView = webViewForTestingAttachments();
     {
         ObserveAttachmentUpdatesForScope observer(webView.get());

trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

@@ -46 +46 @@
 #if PLATFORM(IOS_FAMILY)
 #import "UIKitSPI.h"
+#import <MobileCoreServices/MobileCoreServices.h>
 #import <wtf/SoftLinking.h>
 SOFT_LINK_FRAMEWORK(UIKit)
@@ -273 +274 @@
 #if PLATFORM(IOS_FAMILY)
 
+static NSArray<NSString *> *writableTypeIdentifiersForItemProviderWithoutPublicRTFD()
+{
+    return @[
+        @"com.apple.uikit.attributedstring",
+        (__bridge NSString *)kUTTypeFlatRTFD,
+        (__bridge NSString *)kUTTypeUTF8PlainText,
+    ];
+}
+
+static void applyWorkaroundToAllowWritingAttributedStringsToItemProviders()
+{
+    // FIXME: Remove this once <rdar://problem/51510554> is fixed.
+    static std::unique_ptr<ClassMethodSwizzler> swizzler;
+    static dispatch_once_t onceToken;
+    dispatch_once(&onceToken, ^{
+        swizzler = std::make_unique<ClassMethodSwizzler>(NSAttributedString.class, @selector(writableTypeIdentifiersForItemProvider), reinterpret_cast<IMP>(writableTypeIdentifiersForItemProviderWithoutPublicRTFD));
+    });
+}
+
 using InputSessionChangeCount = NSUInteger;
 static InputSessionChangeCount nextInputSessionChangeCount()
@@ -324 +344 @@
     _sharedCalloutBarSwizzler = std::make_unique<ClassMethodSwizzler>([UICalloutBar class], @selector(sharedCalloutBar), reinterpret_cast<IMP>(suppressUICalloutBar));
     _inputSessionChangeCount = 0;
+    applyWorkaroundToAllowWritingAttributedStringsToItemProviders();
 #endif