Changeset 246267 in webkit

Timestamp:

Jun 10, 2019 10:41:32 AM (5 years ago)

Author:

ajuma@chromium.org

Message:

REGRESSION (r245396): Page load time performance regression
​https://bugs.webkit.org/show_bug.cgi?id=198382

Reviewed by Per Arne Vollan.

Use a delay of 2000ms instead of 500ms when scheduling rendering updates
for IntersectionObserver targets added during page load. This is a
speculative fix for a page load time regression caused by r245396 and
still not fixed after r245958.

• dom/Document.cpp:

(WebCore::Document::scheduleTimedRenderingUpdate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-10  Ali Juma  <ajuma@chromium.org>
+
+        REGRESSION (r245396): Page load time performance regression
+        https://bugs.webkit.org/show_bug.cgi?id=198382
+
+        Reviewed by Per Arne Vollan.
+
+        Use a delay of 2000ms instead of 500ms when scheduling rendering updates
+        for IntersectionObserver targets added during page load. This is a
+        speculative fix for a page load time regression caused by r245396 and
+        still not fixed after r245958.
+
+        * dom/Document.cpp:
+        (WebCore::Document::scheduleTimedRenderingUpdate):
+
 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -354 +354 @@
 
 #if ENABLE(INTERSECTION_OBSERVER)
-static const Seconds intersectionObserversInitialUpdateDelay { 500_ms };
+static const Seconds intersectionObserversInitialUpdateDelay { 2000_ms };
 #endif
 
@@ -7295 +7295 @@
 void Document::scheduleTimedRenderingUpdate()
 {
+#if ENABLE(INTERSECTION_OBSERVER)
+    m_intersectionObserversInitialUpdateTimer.stop();
+#endif
     if (auto page = this->page())
         page->renderingUpdateScheduler().scheduleTimedRenderingUpdate();