Changeset 246269 in webkit

Timestamp:

Jun 10, 2019 11:01:05 AM (5 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: xcrun simctl spawn * launchctl print system output is not utf-8
​https://bugs.webkit.org/show_bug.cgi?id=198723

Reviewed by Aakash Jain.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/xcode/simulated_device.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-10  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
+        https://bugs.webkit.org/show_bug.cgi?id=198723
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/xcode/simulated_device.py:
+        (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
+
 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py

@@ -535 +535 @@
             return True
 
-        for line in self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'print', 'system']).splitlines():
+        for line in self.executive.run_command([SimulatedDeviceManager.xcrun, 'simctl', 'spawn', self.udid, 'launchctl', 'print', 'system'], decode_output=False).splitlines():
             if home_screen_service in line:
                 return True