Changeset 246338 in webkit
- Timestamp:
- Jun 11, 2019 4:00:58 PM (5 years ago)
- Location:
- trunk/LayoutTests
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r246336 r246338 1 2019-06-11 Daniel Bates <dabates@apple.com> 2 3 [iOS] Adjust test fast/events/ios/keyup.html to ignore Shift keyups 4 https://bugs.webkit.org/show_bug.cgi?id=198768 5 <rdar://problem/46082743> 6 7 Reviewed by Brent Fulgham. 8 9 Ignore Shift keyups as in the future they will be emitted. We have existing test coverage for them 10 currently skipped in OpenSource that will be unskipped in the future once we enable ENABLE(FULL_KEYBOARD_ACCESS). 11 12 * fast/events/ios/keyup.html: 13 1 14 2019-06-11 Daniel Bates <dabates@apple.com> 2 15 -
trunk/LayoutTests/fast/events/ios/keyup.html
r235759 r246338 27 27 function logKeyEvent(event) 28 28 { 29 let pieces = []; 30 for (let propertyName of ["type", "key", "code", "keyIdentifier", "keyCode", "charCode", "keyCode", "which"]) 31 pieces.push(`${propertyName}: ${event[propertyName]}`); 32 log(pieces.join(", ")); 29 // Ignore Shift keyups, if they are dispatched, as not all versions of iOS dispatch them. 30 if (event.key == "Shift") 31 ++numberOfFiredKeyEventsForTestComplete; 32 if (event.key !== "Shift") { 33 let pieces = []; 34 for (let propertyName of ["type", "key", "code", "keyIdentifier", "keyCode", "charCode", "keyCode", "which"]) 35 pieces.push(`${propertyName}: ${event[propertyName]}`); 36 log(pieces.join(", ")); 37 } 33 38 if (++numberOfFiredKeyEvents >= numberOfFiredKeyEventsForTestComplete && window.testRunner) 34 39 testRunner.notifyDone();
Note: See TracChangeset
for help on using the changeset viewer.