Changeset 246352 in webkit

Timestamp:

Jun 12, 2019 7:50:16 AM (5 years ago)

Author:

Michael Catanzaro

Message:

[WPE][GTK] Enable hyperlink auditing
​https://bugs.webkit.org/show_bug.cgi?id=197845

Reviewed by Carlos Garcia Campos.

Source/WebKit:

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):

Tools:

• TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Enable hyperlink auditing
+        https://bugs.webkit.org/show_bug.cgi?id=197845
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UIProcess/API/glib/WebKitSettings.cpp:
+        (webkit_settings_class_init):
+
 2019-06-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
 

trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp

@@ -780 +780 @@
                                                          _("Enable hyperlink auditing"),
                                                          _("Whether <a ping> should be able to send pings."),
-                                                         FALSE,
+                                                         TRUE,
                                                          readWriteConstructParamFlags));
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [WPE][GTK] Enable hyperlink auditing
+        https://bugs.webkit.org/show_bug.cgi?id=197845
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
+        (testWebKitSettings):
+
 2019-06-11  Keith Rollin  <krollin@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp

@@ -97 +97 @@
     g_assert_true(webkit_settings_get_javascript_can_open_windows_automatically(settings));
 
-    // By default hyper link auditing is disabled.
+    // By default hyper link auditing is enabled.
+    g_assert_true(webkit_settings_get_enable_hyperlink_auditing(settings));
+    webkit_settings_set_enable_hyperlink_auditing(settings, FALSE);
     g_assert_false(webkit_settings_get_enable_hyperlink_auditing(settings));
-    webkit_settings_set_enable_hyperlink_auditing(settings, TRUE);
-    g_assert_true(webkit_settings_get_enable_hyperlink_auditing(settings));
 
     // Default font family is "sans-serif".