Changeset 246373 in webkit

Timestamp:

Jun 12, 2019 1:38:18 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

Replace double-quotes with single quotes in loadConfig.py
​https://bugs.webkit.org/show_bug.cgi?id=198792

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/loadConfig.py:
• BuildSlaveSupport/ews-build/steps_unittest.py:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/loadConfig.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/loadConfig.py

@@ -59 +59 @@
         builder['tags'] = getTagsForBuilder(builder)
         factory = globals()[builder['factory']]
-        builder['description'] = builder.pop("shortname")
+        builder['description'] = builder.pop('shortname')
         factorykwargs = {}
-        for key in ["platform", "configuration", "architectures", "triggers", "additionalArguments"]:
+        for key in ['platform', 'configuration', 'architectures', 'triggers', 'additionalArguments']:
             value = builder.pop(key, None)
             if value:
                 factorykwargs[key] = value
 
-        builder["factory"] = factory(**factorykwargs)
+        builder['factory'] = factory(**factorykwargs)
 
         if use_localhost_worker:
-            builder['workernames'].append("local-worker")
+            builder['workernames'].append('local-worker')
 
         c['builders'].append(builder)

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -478 +478 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=["perl", "Tools/Scripts/build-webkit", '--release'],
+                        command=['perl', 'Tools/Scripts/build-webkit', '--release'],
                         )
             + 0,
@@ -491 +491 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=["perl", "Tools/Scripts/build-webkit", '--debug'],
+                        command=['perl', 'Tools/Scripts/build-webkit', '--debug'],
                         )
             + ExpectShell.log('stdio', stdout='1 error generated.')
@@ -560 +560 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=["perl", "Tools/Scripts/build-jsc", '--release'],
+                        command=['perl', 'Tools/Scripts/build-jsc', '--release'],
                         )
             + 0,
@@ -573 +573 @@
         self.expectRemoteCommands(
             ExpectShell(workdir='wkdir',
-                        command=["perl", "Tools/Scripts/build-jsc", '--debug'],
+                        command=['perl', 'Tools/Scripts/build-jsc', '--debug'],
                         )
             + ExpectShell.log('stdio', stdout='1 error generated.')

trunk/Tools/ChangeLog

@@ +1 @@
+2019-06-12  Aakash Jain  <aakash_jain@apple.com>
+
+        Replace double-quotes with single quotes in loadConfig.py
+        https://bugs.webkit.org/show_bug.cgi?id=198792
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/loadConfig.py:
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+
 22019-06-11  Brent Fulgham  <bfulgham@apple.com>