Changeset 246403 in webkit

Timestamp:

Jun 13, 2019 8:07:18 AM (5 years ago)

Author:

youenn@apple.com

Message:

Update service worker test and expectation after revision 246363
​https://bugs.webkit.org/show_bug.cgi?id=198808

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:

Make sure the fetch load finishes so that removing the frame does not cancel the fetch.

LayoutTests:

• TestExpectations:

Skip timing out test in Debug

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• TestExpectations (modified) (2 diffs)
• imported/w3c/ChangeLog (modified) (1 diff)
• imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt (modified) (1 diff)
• imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-13  Youenn Fablet  <youenn@apple.com>
+
+        Update service worker test and expectation after revision 246363
+        https://bugs.webkit.org/show_bug.cgi?id=198808
+
+        Reviewed by Geoffrey Garen.
+
+        * TestExpectations:
+        Skip timing out test in Debug
+
 2019-06-13  Miguel Gomez  <magomez@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -214 +214 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/update-not-allowed.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/worker-in-sandboxed-iframe-by-csp-fetch-event.https.html [ Skip ]
+[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Skip ]
 
 # Newly imported service worker tests that are flaky.
@@ -282 +283 @@
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html [ Slow ]
-[ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/multiple-update.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Slow ]

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2019-06-13  Youenn Fablet  <youenn@apple.com>
+
+        Update service worker test and expectation after revision 246363
+        https://bugs.webkit.org/show_bug.cgi?id=198808
+
+        Reviewed by Geoffrey Garen.
+
+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
+        * web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html:
+        Make sure the fetch load finishes so that removing the frame does not cancel the fetch.
+
 2019-06-12  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt

@@ -1 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: cancelled
-
-Harness Error (FAIL), message = cancelled
 
 PASS global setup 

trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https.html

@@ -45 +45 @@
 
   // Start a fetch.
-  frame.contentWindow.fetch(url);
+  const fetchPromise = frame.contentWindow.fetch(url);
 
   // Receive the test result from the service worker.
-  return wait_for_message();
+  const result = wait_for_message();
+  await fetchPromise.then(()=> {}, () => {});
+  return result;
 };