Changeset 246404 in webkit
- Timestamp:
- Jun 13, 2019 9:05:27 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r246403 r246404 1 2019-06-13 Antoine Quint <graouts@apple.com> 2 3 "display: contents" Content click does not trigger 4 https://bugs.webkit.org/show_bug.cgi?id=198559 5 <rdar://problem/51488524> 6 7 Reviewed by Antti Koivisto. 8 9 Add a new test that checks that tapping on an element with "display: contents" correctly gets a "click" event. 10 11 * fast/events/ios/click-event-and-display-contents-expected.txt: Added. 12 * fast/events/ios/click-event-and-display-contents.html: Added. 13 1 14 2019-06-13 Youenn Fablet <youenn@apple.com> 2 15 -
trunk/Source/WebCore/ChangeLog
r246401 r246404 1 2019-06-13 Antoine Quint <graouts@apple.com> 2 3 "display: contents" Content click does not trigger 4 https://bugs.webkit.org/show_bug.cgi?id=198559 5 <rdar://problem/51488524> 6 7 Reviewed by Antti Koivisto. 8 9 Test: fast/events/ios/click-event-and-display-contents.html 10 11 * dom/Element.h: 12 1 13 2019-06-13 Takashi Komori <Takashi.Komori@sony.com> 2 14 -
trunk/Source/WebCore/dom/Element.h
r245868 r246404 541 541 542 542 const RenderStyle* existingComputedStyle() const; 543 const RenderStyle* renderOrDisplayContentsStyle() const;543 WEBCORE_EXPORT const RenderStyle* renderOrDisplayContentsStyle() const; 544 544 545 545 void setBeforePseudoElement(Ref<PseudoElement>&&); -
trunk/Source/WebKit/ChangeLog
r246401 r246404 1 2019-06-13 Antoine Quint <graouts@apple.com> 2 3 "display: contents" Content click does not trigger 4 https://bugs.webkit.org/show_bug.cgi?id=198559 5 <rdar://problem/51488524> 6 7 Reviewed by Antti Koivisto. 8 9 * WebProcess/WebPage/ios/WebPageIOS.mm: 10 (WebKit::WebPage::commitPotentialTap): 11 1 12 2019-06-13 Takashi Komori <Takashi.Komori@sony.com> 2 13 -
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
r246357 r246404 1059 1059 }; 1060 1060 1061 auto invalidTargetForSingleClick = !m_potentialTapNode || (!m_potentialTapNode->renderer() && !is<HTMLAreaElement>(m_potentialTapNode.get())); 1061 auto invalidTargetForSingleClick = !m_potentialTapNode; 1062 if (!invalidTargetForSingleClick) { 1063 bool targetRenders = m_potentialTapNode->renderer(); 1064 if (!targetRenders && is<Element>(m_potentialTapNode.get())) 1065 targetRenders = downcast<Element>(*m_potentialTapNode).renderOrDisplayContentsStyle(); 1066 invalidTargetForSingleClick = !targetRenders && !is<HTMLAreaElement>(m_potentialTapNode.get()); 1067 } 1062 1068 if (invalidTargetForSingleClick) { 1063 1069 // When the node has no click eventlistener, but it may have a dblclick one.
Note: See TracChangeset
for help on using the changeset viewer.