Changeset 246444 in webkit
- Timestamp:
- Jun 14, 2019 2:00:13 PM (5 years ago)
- Location:
- trunk/Source
- Files:
-
- 15 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r246441 r246444 1 2019-06-14 Megan Gardner <megan_gardner@apple.com> 2 3 Move Synthetic Editing Commands to behind an experimental feature flag 4 https://bugs.webkit.org/show_bug.cgi?id=198842 5 <rdar://problem/50594700> 6 7 Reviewed by Simon Fraser. 8 9 Moving from a quirk to a feature flag. 10 11 * page/Quirks.cpp: 12 (WebCore::shouldEmulateEditingButtonsAndGesturesInHiddenEditableAreasForHost): Deleted. 13 (WebCore::Quirks::shouldEmulateEditingButtonsAndGesturesInHiddenEditableAreas const): Deleted. 14 * page/Quirks.h: 15 * page/RuntimeEnabledFeatures.h: 16 (WebCore::RuntimeEnabledFeatures::setSyntheticEditingCommandsEnabled): 17 (WebCore::RuntimeEnabledFeatures::syntheticEditingCommandsEnabled const): 18 1 19 2019-06-14 Jer Noble <jer.noble@apple.com> 2 20 -
trunk/Source/WebCore/page/Quirks.cpp
r246319 r246444 243 243 } 244 244 245 static bool shouldEmulateEditingButtonsAndGesturesInHiddenEditableAreasForHost(const StringView& host)246 {247 #if PLATFORM(IOS_FAMILY)248 return equalLettersIgnoringASCIICase(host, "docs.google.com");249 #else250 UNUSED_PARAM(host);251 return false;252 #endif253 }254 255 245 bool Quirks::shouldDispatchSyntheticMouseEventsWhenModifyingSelection() const 256 246 { … … 269 259 270 260 return false; 271 }272 273 bool Quirks::shouldEmulateEditingButtonsAndGesturesInHiddenEditableAreas() const274 {275 if (!needsQuirks())276 return false;277 278 return shouldEmulateEditingButtonsAndGesturesInHiddenEditableAreasForHost(m_document->topDocument().url().host());279 261 } 280 262 -
trunk/Source/WebCore/page/Quirks.h
r246226 r246444 59 59 WEBCORE_EXPORT bool shouldDispatchSyntheticMouseEventsWhenModifyingSelection() const; 60 60 WEBCORE_EXPORT bool shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreas() const; 61 WEBCORE_EXPORT bool shouldEmulateEditingButtonsAndGesturesInHiddenEditableAreas() const;62 61 WEBCORE_EXPORT bool isTouchBarUpdateSupressedForHiddenContentEditable() const; 63 62 WEBCORE_EXPORT bool isNeverRichlyEditableForTouchBar() const; -
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
r246388 r246444 184 184 void setPointerEventsEnabled(bool isEnabled) { m_pointerEventsEnabled = isEnabled; } 185 185 bool pointerEventsEnabled() const { return m_pointerEventsEnabled; } 186 187 void setSyntheticEditingCommandsEnabled(bool isEnabled) { m_syntheticEditingCommandsEnabled = isEnabled; } 188 bool syntheticEditingCommandsEnabled() const { return m_syntheticEditingCommandsEnabled; } 186 189 187 190 #if ENABLE(LAYOUT_FORMATTING_CONTEXT) … … 417 420 bool m_CSSCustomPropertiesAndValuesEnabled { false }; 418 421 bool m_pointerEventsEnabled { true }; 422 bool m_syntheticEditingCommandsEnabled { true }; 419 423 bool m_webSQLEnabled { true }; 420 424 bool m_pageAtRuleSupportEnabled { false }; -
trunk/Source/WebCore/page/Settings.yaml
r246285 r246444 587 587 initial: false 588 588 589 syntheticEditingCommandsEnabled: 590 initial: true 591 589 592 CSSOMViewScrollingAPIEnabled: 590 593 initial: false -
trunk/Source/WebKit/ChangeLog
r246425 r246444 1 2019-06-14 Megan Gardner <megan_gardner@apple.com> 2 3 Move Synthetic Editing Commands to behind an experimental feature flag 4 https://bugs.webkit.org/show_bug.cgi?id=198842 5 <rdar://problem/50594700> 6 7 Reviewed by Simon Fraser. 8 9 Add a feature flag to gate synthetic editing commands. 10 11 * Shared/WebPreferences.yaml: 12 * WebProcess/WebPage/ios/WebPageIOS.mm: 13 (WebKit::WebPage::getFocusedElementInformation): 14 1 15 2019-06-13 Megan Gardner <megan_gardner@apple.com> 2 16 -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r246388 r246444 1255 1255 category: experimental 1256 1256 1257 SyntheticEditingCommandsEnabled: 1258 type: bool 1259 defaultValue: true 1260 humanReadableName: "Synthetic Editing Commands" 1261 humanReadableDescription: "Enable Synthetic Editing Commands" 1262 category: experimental 1263 1257 1264 CSSOMViewScrollingAPIEnabled: 1258 1265 type: bool -
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
r242738 r246444 1981 1981 } 1982 1982 1983 void WKPreferencesSetSyntheticEditingCommandsEnabled(WKPreferencesRef preferencesRef, bool flag) 1984 { 1985 toImpl(preferencesRef)->setSyntheticEditingCommandsEnabled(flag); 1986 } 1987 1988 bool WKPreferencesGetSyntheticEditingCommandsEnabled(WKPreferencesRef preferencesRef) 1989 { 1990 return toImpl(preferencesRef)->syntheticEditingCommandsEnabled(); 1991 } 1992 1983 1993 void WKPreferencesSetCSSOMViewScrollingAPIEnabled(WKPreferencesRef preferencesRef, bool flag) 1984 1994 { -
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
r242621 r246444 560 560 WK_EXPORT bool WKPreferencesGetAriaReflectionEnabled(WKPreferencesRef); 561 561 562 // Defaults to true. 563 WK_EXPORT void WKPreferencesSetSyntheticEditingCommandsEnabled(WKPreferencesRef, bool); 564 WK_EXPORT bool WKPreferencesGetSyntheticEditingCommandsEnabled(WKPreferencesRef); 565 562 566 // Defaults to false. 563 567 WK_EXPORT void WKPreferencesSetCSSOMViewScrollingAPIEnabled(WKPreferencesRef, bool); -
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
r246404 r246444 2944 2944 information.autocapitalizeType = focusedElement.autocapitalizeType(); 2945 2945 information.inputMode = focusedElement.canonicalInputMode(); 2946 information.shouldSynthesizeKeyEventsForEditing = focusedElement.document(). quirks().shouldEmulateEditingButtonsAndGesturesInHiddenEditableAreas();2946 information.shouldSynthesizeKeyEventsForEditing = focusedElement.document().settings().syntheticEditingCommandsEnabled(); 2947 2947 } else { 2948 2948 information.isAutocorrect = true; -
trunk/Source/WebKitLegacy/mac/ChangeLog
r246429 r246444 1 2019-06-14 Megan Gardner <megan_gardner@apple.com> 2 3 Move Synthetic Editing Commands to behind an experimental feature flag 4 https://bugs.webkit.org/show_bug.cgi?id=198842 5 <rdar://problem/50594700> 6 7 Reviewed by Simon Fraser. 8 9 Add plumbing for synthetic editing command feature flag. 10 11 * WebView/WebPreferenceKeysPrivate.h: 12 * WebView/WebPreferences.mm: 13 (+[WebPreferences initialize]): 14 (-[WebPreferences syntheticEditingCommandsEnabled]): 15 (-[WebPreferences setSyntheticEditingCommandsEnabled:]): 16 * WebView/WebPreferencesPrivate.h: 17 * WebView/WebView.mm: 18 (-[WebView _preferencesChanged:]): 19 1 20 2019-06-13 Antoine Quint <graouts@apple.com> 2 21 -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
r246045 r246444 55 55 #define WebKitWebAnimationsEnabledPreferenceKey @"WebKitWebAnimationsEnabled" 56 56 #define WebKitPointerEventsEnabledPreferenceKey @"WebKitPointerEventsEnabled" 57 #define WebKitSyntheticEditingCommandsEnabledPreferenceKey @"WebKitSyntheticEditingCommandsEnabled" 57 58 #define WebKitWebSecurityEnabledPreferenceKey @"WebKitWebSecurityEnabled" 58 59 #define WebKitAllowUniversalAccessFromFileURLsPreferenceKey @"WebKitAllowUniversalAccessFromFileURLs" -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
r246285 r246444 644 644 [NSNumber numberWithBool:YES], WebKitWebAnimationsEnabledPreferenceKey, 645 645 [NSNumber numberWithBool:YES], WebKitPointerEventsEnabledPreferenceKey, 646 [NSNumber numberWithBool:YES], WebKitSyntheticEditingCommandsEnabledPreferenceKey, 646 647 647 648 #if PLATFORM(IOS_FAMILY) … … 3157 3158 } 3158 3159 3160 - (BOOL)syntheticEditingCommandsEnabled 3161 { 3162 return [self _boolValueForKey:WebKitPointerEventsEnabledPreferenceKey]; 3163 } 3164 3165 - (void)setSyntheticEditingCommandsEnabled:(BOOL)flag 3166 { 3167 [self _setBoolValue:flag forKey:WebKitPointerEventsEnabledPreferenceKey]; 3168 } 3169 3159 3170 - (BOOL)fetchAPIKeepAliveEnabled 3160 3171 { -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
r246045 r246444 573 573 - (void)setPointerEventsEnabled:(BOOL)flag; 574 574 - (BOOL)pointerEventsEnabled; 575 576 - (void)setSyntheticEditingCommandsEnabled:(BOOL)flag; 577 - (BOOL)syntheticEditingCommandsEnabled; 575 578 576 579 - (void)setFetchAPIKeepAliveEnabled:(BOOL)flag; -
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
r246285 r246444 2982 2982 2983 2983 settings.setVisualViewportAPIEnabled([preferences visualViewportAPIEnabled]); 2984 settings.setSyntheticEditingCommandsEnabled([preferences syntheticEditingCommandsEnabled]); 2984 2985 settings.setCSSOMViewScrollingAPIEnabled([preferences CSSOMViewScrollingAPIEnabled]); 2985 2986 settings.setMediaContentTypesRequiringHardwareSupport([preferences mediaContentTypesRequiringHardwareSupport]);
Note: See TracChangeset
for help on using the changeset viewer.