Changeset 246445 in webkit
- Timestamp:
- Jun 14, 2019 2:17:02 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r246440 r246445 1 2019-06-14 Antoine Quint <graouts@apple.com> 2 3 [Pointer Events] button property is -1 for pointerdown and pointerup 4 https://bugs.webkit.org/show_bug.cgi?id=198868 5 <rdar://problem/51758109> 6 7 Reviewed by Dean Jackson. 8 9 * pointerevents/mouse/pointer-button-and-buttons-expected.txt: Added. 10 * pointerevents/mouse/pointer-button-and-buttons.html: Added. 11 * pointerevents/utils.js: 12 (prototype._handlePointerEvent): 13 1 14 2019-06-14 John Wilander <wilander@apple.com> 2 15 -
trunk/LayoutTests/pointerevents/utils.js
r246213 r246445 70 70 pressure: event.pressure, 71 71 isPrimary: event.isPrimary, 72 isTrusted: event.isTrusted 72 isTrusted: event.isTrusted, 73 button: event.button, 74 buttons: event.buttons 73 75 }); 74 76 } -
trunk/Source/WebCore/ChangeLog
r246444 r246445 1 2019-06-14 Antoine Quint <graouts@apple.com> 2 3 [Pointer Events] button property is -1 for pointerdown and pointerup 4 https://bugs.webkit.org/show_bug.cgi?id=198868 5 <rdar://problem/51758109> 6 7 Reviewed by Dean Jackson. 8 9 A value of -1 for "button", which means there was no change of pressed button since the last event, should only ever be used for "pointermove" events. 10 11 Test: pointerevents/mouse/pointer-button-and-buttons.html 12 13 * page/PointerCaptureController.cpp: 14 (WebCore::PointerCaptureController::pointerEventForMouseEvent): 15 1 16 2019-06-14 Megan Gardner <megan_gardner@apple.com> 2 17 -
trunk/Source/WebCore/page/PointerCaptureController.cpp
r246122 r246445 242 242 243 243 short newButton = mouseEvent.button(); 244 short button = newButton == capturingData.previousMouseButton? -1 : newButton;244 short button = (type == names.mousemoveEvent && newButton == capturingData.previousMouseButton) ? -1 : newButton; 245 245 246 246 // https://w3c.github.io/pointerevents/#chorded-button-interactions
Note: See TracChangeset
for help on using the changeset viewer.