Changeset 246446 in webkit


Ignore:
Timestamp:
Jun 14, 2019 2:39:07 PM (5 years ago)
Author:
jiewen_tan@apple.com
Message:

Disable AppSSO for web processes and plugin processes
​https://bugs.webkit.org/show_bug.cgi?id=198843
<rdar://problem/51642920>

Reviewed by Sam Weinig.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Adds a SPI to disable AppSSO for CFNetwork.

Source/WebKit:

This patch moves the disabling of AppSSO from AuxiliaryProcess to PluginProcess
and WebProcess such that NetworkingProcess will not be affected.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializePluginProcess):

  • Shared/ios/AuxiliaryProcessIOS.mm:

(WebKit::AuxiliaryProcess::platformInitialize):

  • Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::AuxiliaryProcess::platformInitialize):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeProcess):

Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/PAL/ChangeLog

    r246395 r246446  
     12019-06-14  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Disable AppSSO for web processes and plugin processes
     4        https://bugs.webkit.org/show_bug.cgi?id=198843
     5        <rdar://problem/51642920>
     6
     7        Reviewed by Sam Weinig.
     8
     9        * pal/spi/cf/CFNetworkSPI.h:
     10        Adds a SPI to disable AppSSO for CFNetwork.
     11
    1122019-06-12  Antoine Quint  <graouts@apple.com>
    213

  • trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h

    r245075 r246446  
    233233#endif
    234234
     235@interface NSURLSession (SPI)
    235236#if HAVE(CFNETWORK_NSURLSESSION_STRICTRUSTEVALUATE)
    236 @interface NSURLSession (SPI)
    237237+ (void)_strictTrustEvaluate:(NSURLAuthenticationChallenge *)challenge queue:(dispatch_queue_t)queue completionHandler:(void (^)(NSURLAuthenticationChallenge *challenge, OSStatus trustResult))cb;
    238 @end
    239 #endif
     238#endif
     239#if HAVE(LOAD_OPTIMIZER)
     240+ (void)_disableAppSSO;
     241#endif
     242@end
    240243
    241244extern NSString * const NSURLAuthenticationMethodOAuth;

  • trunk/Source/WebKit/ChangeLog

    r246444 r246446  
     12019-06-14  Jiewen Tan  <jiewen_tan@apple.com>
     2
     3        Disable AppSSO for web processes and plugin processes
     4        https://bugs.webkit.org/show_bug.cgi?id=198843
     5        <rdar://problem/51642920>
     6
     7        Reviewed by Sam Weinig.
     8
     9        This patch moves the disabling of AppSSO from AuxiliaryProcess to PluginProcess
     10        and WebProcess such that NetworkingProcess will not be affected.
     11
     12        * PluginProcess/mac/PluginProcessMac.mm:
     13        (WebKit::PluginProcess::platformInitializePluginProcess):
     14        * Shared/ios/AuxiliaryProcessIOS.mm:
     15        (WebKit::AuxiliaryProcess::platformInitialize):
     16        * Shared/mac/AuxiliaryProcessMac.mm:
     17        (WebKit::AuxiliaryProcess::platformInitialize):
     18        * WebProcess/cocoa/WebProcessCocoa.mm:
     19        (WebKit::WebProcess::platformInitializeProcess):
     20
    1212019-06-14  Megan Gardner  <megan_gardner@apple.com>
    222

  • trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm

    r243784 r246446  
    4848#import <mach/vm_statistics.h>
    4949#import <objc/runtime.h>
     50#import <pal/spi/cf/CFNetworkSPI.h>
    5051#import <pal/spi/cg/CoreGraphicsSPI.h>
    5152#import <pal/spi/cocoa/LaunchServicesSPI.h>
    … …  
    405406    [NSApp setAppearance:[NSAppearance appearanceNamed:NSAppearanceNameAqua]];
    406407#endif
     408#if HAVE(LOAD_OPTIMIZER)
     409    [NSURLSession _disableAppSSO];
     410#endif
    407411}
    408412

  • trunk/Source/WebKit/Shared/ios/AuxiliaryProcessIOS.mm

    r246008 r246446  
    4444#endif
    4545
    46 #if USE(APPLE_INTERNAL_SDK)
    47 #include <WebKitAdditions/AuxiliaryProcessAdditions.h>
    48 #endif
    49 
    5046namespace WebKit {
    5147
    … …  
    5652    floatingPointEnvironment.saveMainThreadEnvironment();
    5753    [[NSFileManager defaultManager] changeCurrentDirectoryPath:[[NSBundle mainBundle] bundlePath]];
    58 #if HAVE(LOAD_OPTIMIZER)
    59 AUXILIARYPROCESS_LOADOPTIMIZER_ADDITIONS
    60 #endif
    6154}
    6255

  • trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm

    r246008 r246446  
    5858#if USE(APPLE_INTERNAL_SDK)
    5959#import <ApplicationServices/ApplicationServicesPriv.h>
    60 #import <WebKitAdditions/AuxiliaryProcessAdditions.h>
    6160#import <rootless.h>
    6261#endif
    … …  
    161160    initializeTimerCoalescingPolicy();
    162161    [[NSFileManager defaultManager] changeCurrentDirectoryPath:[[NSBundle mainBundle] bundlePath]];
    163 #if HAVE(LOAD_OPTIMIZER)
    164 AUXILIARYPROCESS_LOADOPTIMIZER_ADDITIONS
    165 #endif
    166162}
    167163

  • trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

    r246413 r246446  
    6868#import <dispatch/dispatch.h>
    6969#import <objc/runtime.h>
     70#import <pal/spi/cf/CFNetworkSPI.h>
    7071#import <pal/spi/cf/CFUtilitiesSPI.h>
    7172#import <pal/spi/cg/CoreGraphicsSPI.h>
    … …  
    456457    registerWithStateDumper();
    457458#endif
     459
     460#if HAVE(LOAD_OPTIMIZER)
     461    [NSURLSession _disableAppSSO];
     462#endif
    458463}
    459464
Note: See TracChangeset for help on using the changeset viewer.