Changeset 246564 in webkit

Timestamp:

Jun 18, 2019 1:59:35 PM (5 years ago)

Author:

dbates@webkit.org

Message:

[iOS] Pressing key while holding Command should not insert character
​https://bugs.webkit.org/show_bug.cgi?id=198925
<rdar://problem/51778811>

Reviewed by Brent Fulgham.

Source/WebKit:

Do not insert a character for an unhandled key command that has a Command modifier.
For example, pressing Command + Shift + v, which is an unhandled key command (at the
time of writing) should not insert v. This matches iOS and Mac platform conventions.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]):

LayoutTests:

Add a test that Command + Shift + v does not insert a v as we don't expect it
to as of the time of writing. A more comprehensive test would be needed to
ensure that all unhandled key commands with Command modifiers do not insert
a character. For now, the added test seems good enough.

• fast/events/ios/command+shift+v-should-not-insert-v-expected.txt: Added.
• fast/events/ios/command+shift+v-should-not-insert-v.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/ios/command+shift+v-should-not-insert-v-expected.txt (added)
• LayoutTests/fast/events/ios/command+shift+v-should-not-insert-v.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-18  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Pressing key while holding Command should not insert character
+        https://bugs.webkit.org/show_bug.cgi?id=198925
+        <rdar://problem/51778811>
+
+        Reviewed by Brent Fulgham.
+
+        Add a test that Command + Shift + v does not insert a v as we don't expect it
+        to as of the time of writing. A more comprehensive test would be needed to
+        ensure that all unhandled key commands with Command modifiers do not insert
+        a character. For now, the added test seems good enough.
+
+        * fast/events/ios/command+shift+v-should-not-insert-v-expected.txt: Added.
+        * fast/events/ios/command+shift+v-should-not-insert-v.html: Added.
+
 2019-06-18  Russell Epstein  <russell_e@apple.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-18  Daniel Bates  <dabates@apple.com>
+
+        [iOS] Pressing key while holding Command should not insert character
+        https://bugs.webkit.org/show_bug.cgi?id=198925
+        <rdar://problem/51778811>
+
+        Reviewed by Brent Fulgham.
+
+        Do not insert a character for an unhandled key command that has a Command modifier.
+        For example, pressing Command + Shift + v, which is an unhandled key command (at the
+        time of writing) should not insert v. This matches iOS and Mac platform conventions.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _interpretKeyEvent:isCharEvent:]):
+
 2019-06-18  John Wilander  <wilander@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -4675 +4675 @@
 #endif
 
+    // Don't insert character for an unhandled Command-key key command. This matches iOS and Mac platform conventions.
+    if (event.modifierFlags & WebEventFlagMaskCommandKey)
+        return NO;
+
     NSString *characters = event.characters;
     if (!characters.length)