Changeset 246584 in webkit


Ignore:
Timestamp:
Jun 19, 2019 3:54:13 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

resize-observer/element-leak.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=198666

Patch by Cathie Chen <cathiechen> on 2019-06-19
Reviewed by Frédéric Wang.

It takes a very long time to construct iframes which create and remove 1000 elements. This would cause timeout sometimes.
In order to make it more effective, reduce the number of elements to 200 and put them into a container first,
then attach the container to DOM tree.

  • resize-observer/resources/element-leak-frame.html:
Location:
trunk/LayoutTests
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r246582 r246584  
     12019-06-19  Cathie Chen  <cathiechen@igalia.com>
     2
     3        resize-observer/element-leak.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=198666
     5
     6        Reviewed by Frédéric Wang.
     7
     8        It takes a very long time to construct iframes which create and remove 1000 elements. This would cause timeout sometimes.
     9        In order to make it more effective, reduce the number of elements to 200 and put them into a container first,
     10        then attach the container to DOM tree.
     11
     12        * resize-observer/resources/element-leak-frame.html:
     13
    1142019-06-18  Megan Gardner  <megan_gardner@apple.com>
    215
  • trunk/LayoutTests/resize-observer/resources/element-leak-frame.html

    r246057 r246584  
    44<script type="text/javascript">
    55
    6 const targetCount = 1000;
     6const targetCount = 200;
    77var resizeObserver = new ResizeObserver( entries => {
    88    for (let entry of entries)
     
    1616});
    1717
     18var container = document.createElement('div');
    1819for (let i = 0; i < targetCount; ++i) {
    1920    var target = document.createElement('div');
    20     document.body.appendChild(target);
     21    container.appendChild(target);
    2122}
     23document.body.appendChild(container);
    2224
    2325document.querySelectorAll('div').forEach(target => resizeObserver.observe(target));
Note: See TracChangeset for help on using the changeset viewer.