Changeset 246650 in webkit


Ignore:
Timestamp:
Jun 20, 2019 1:24:30 PM (5 years ago)
Author:
aakash_jain@apple.com
Message:

[ews-build] Add unit tests for AnalyzeCompileWebKitResults
https://bugs.webkit.org/show_bug.cgi?id=199073

Reviewed by Jonathan Bedard.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

    r246373 r246650  
    3535from twisted.trial import unittest
    3636
    37 from steps import (AnalyzeAPITestsResults, ApplyPatch, ArchiveBuiltProduct, ArchiveTestResults,
     37from steps import (AnalyzeAPITestsResults, AnalyzeCompileWebKitResults, ApplyPatch, ArchiveBuiltProduct, ArchiveTestResults,
    3838                   CheckOutSource, CheckPatchRelevance, CheckStyle, CleanBuild, CleanWorkingDirectory,
    3939                   CompileJSCOnly, CompileJSCOnlyToT, CompileWebKit, CompileWebKitToT, ConfigureBuild,
     
    4747from buildbot.test.fake.fakebuild import FakeBuild
    4848FakeBuild.addStepsAfterCurrentStep = lambda FakeBuild, step_factories: None
     49
     50
     51def mock_step(step, logs='', results=SUCCESS, stopped=False, properties=None):
     52    step.logs = logs
     53    step.results = results
     54    step.stopped = stopped
     55    return step
    4956
    5057
     
    543550        self.expectHidden(True)
    544551        self.expectOutcome(result=SKIPPED, state_string='Compiled WebKit (skipped)')
     552        return self.runStep()
     553
     554
     555class TestAnalyzeCompileWebKitResults(BuildStepMixinAdditions, unittest.TestCase):
     556    def setUp(self):
     557        self.longMessage = True
     558        return self.setUpBuildStep()
     559
     560    def tearDown(self):
     561        return self.tearDownBuildStep()
     562
     563    def test_patch_with_build_failure(self):
     564        previous_steps = [
     565            mock_step(CompileWebKit(), results=FAILURE),
     566            mock_step(CompileWebKitToT(), results=SUCCESS),
     567        ]
     568        self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps)
     569        self.expectOutcome(result=FAILURE, state_string='Patch does not build (failure)')
     570        return self.runStep()
     571
     572    def test_patch_with_ToT_failure(self):
     573        previous_steps = [
     574            mock_step(CompileWebKit(), results=FAILURE),
     575            mock_step(CompileWebKitToT(), results=FAILURE),
     576        ]
     577        self.setupStep(AnalyzeCompileWebKitResults(), previous_steps=previous_steps)
     578        self.expectOutcome(result=FAILURE, state_string='Unable to build WebKit without patch, retrying build (failure)')
    545579        return self.runStep()
    546580
  • trunk/Tools/ChangeLog

    r246639 r246650  
     12019-06-20  Aakash Jain  <aakash_jain@apple.com>
     2
     3        [ews-build] Add unit tests for AnalyzeCompileWebKitResults
     4        https://bugs.webkit.org/show_bug.cgi?id=199073
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
     9
    1102019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
    211
Note: See TracChangeset for help on using the changeset viewer.