Changeset 246673 in webkit

Timestamp:

Jun 21, 2019 12:05:10 AM (5 years ago)

Author:

graouts@webkit.org

Message:

fast/events/ios/click-event-and-display-contents.html times out on iPad
​https://bugs.webkit.org/show_bug.cgi?id=199068
<rdar://problem/51899547>

Reviewed by Dean Jackson.

Querying the bounds of a "display: contents" element will always return 0 width and height. So let's position the element at 0,0
so that we can send a tap at that location and reliably tap on that element.

• fast/events/ios/click-event-and-display-contents.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/ios/click-event-and-display-contents.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-06-20  Antoine Quint  <graouts@apple.com>
+
+        fast/events/ios/click-event-and-display-contents.html times out on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=199068
+        <rdar://problem/51899547>
+
+        Reviewed by Dean Jackson.
+
+        Querying the bounds of a "display: contents" element will always return 0 width and height. So let's position the element at 0,0
+        so that we can send a tap at that location and reliably tap on that element.
+
+        * fast/events/ios/click-event-and-display-contents.html:
+
 2019-06-20  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/fast/events/ios/click-event-and-display-contents.html

@@ -5 +5 @@
 <script src="../../../resources/basic-gestures.js"></script>
 <style>
+
+body {
+    margin: 0;
+}
+
 #target {
     width: 100px;
@@ -27 +32 @@
 
     target.addEventListener("click", event => {
-        document.getElementById("target").innerText = "PASS";
+        target.innerText = "PASS";
         testRunner.notifyDone();
     });
 
-    const bounds = target.getBoundingClientRect();
-    const x = bounds.left + bounds.width / 2;
-    const y = bounds.top + bounds.height / 2;
-    tapAtPoint(x, y);
+    tapAtPoint(0, 0);
 })();