Changeset 246713 in webkit

Timestamp:

Jun 22, 2019 11:28:02 AM (5 years ago)

Author:

Nikita Vasilyev

Message:

REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule
​https://bugs.webkit.org/show_bug.cgi?id=199125
<rdar://problem/52011182>

Reviewed by Matt Baker.

Since SpreadsheetSelectorField's focus handler was removed in r241980, focusing on the selector element
doesn't start editing it.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.startEditingRuleSelector):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule
+        https://bugs.webkit.org/show_bug.cgi?id=199125
+        <rdar://problem/52011182>
+
+        Reviewed by Matt Baker.
+
+        Since SpreadsheetSelectorField's focus handler was removed in r241980, focusing on the selector element
+        doesn't start editing it.
+
+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
+        (WI.SpreadsheetCSSStyleDeclarationSection.prototype.startEditingRuleSelector):
+
 2019-06-22  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js

@@ -146 +146 @@
 
         if (this._style.selectorEditable)
-            this._selectorElement.focus();
+            this._selectorTextField.startEditing();
         else
             this._propertiesEditor.startEditingFirstProperty();