Changeset 246732 in webkit

Timestamp:

Jun 24, 2019 7:34:47 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Navigation gesture should use dark fallback bg color on dark themes
​https://bugs.webkit.org/show_bug.cgi?id=199104

Patch by Alexander Mikhaylenko <​exalm7659@gmail.com> on 2019-06-24
Reviewed by Michael Catanzaro.

Use theme_base_color instead of white background for swipe gesture fallback if no snapshot is found and
the page did not specify a color. This allows it to use dark colors for dark themes. If the color was
not found, still fall back to white.

• UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::ViewGestureController::beginSwipeGesture):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/gtk/ViewGestureControllerGtk.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-24  Alexander Mikhaylenko  <exalm7659@gmail.com>
+
+        [GTK] Navigation gesture should use dark fallback bg color on dark themes
+        https://bugs.webkit.org/show_bug.cgi?id=199104
+
+        Reviewed by Michael Catanzaro.
+
+        Use theme_base_color instead of white background for swipe gesture fallback if no snapshot is found and
+        the page did not specify a color. This allows it to use dark colors for dark themes. If the color was
+        not found, still fall back to white.
+
+        * UIProcess/gtk/ViewGestureControllerGtk.cpp:
+        (WebKit::ViewGestureController::beginSwipeGesture):
+
 2019-06-23  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp

@@ -313 +313 @@
     }
 
+    if (!m_currentSwipeSnapshotPattern) {
+        GdkRGBA color;
+        auto* context = gtk_widget_get_style_context(m_webPageProxy.viewWidget());
+        if (gtk_style_context_lookup_color(context, "theme_base_color", &color))
+            m_currentSwipeSnapshotPattern = adoptRef(cairo_pattern_create_rgba(color.red, color.green, color.blue, color.alpha));
+    }
+
     if (!m_currentSwipeSnapshotPattern)
         m_currentSwipeSnapshotPattern = adoptRef(cairo_pattern_create_rgb(1, 1, 1));