Changeset 246754 in webkit

Timestamp:

Jun 24, 2019 12:32:03 PM (5 years ago)

Author:

pvollan@apple.com

Message:

[Cocoa] Avoid creating a PlatformMediaSessionManager when the WebProcess is suspended or resumed
​https://bugs.webkit.org/show_bug.cgi?id=199160

Reviewed by Brent Fulgham.

When the WebProcess suspends or resumes, the PlatformMediaSessionManager is notified about this.
Avoid creating a new PlatformMediaSessionManager if it does not already exist.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::processDidResume):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebProcess.cpp (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-06-24  Per Arne Vollan  <pvollan@apple.com>
+
+        [Cocoa] Avoid creating a PlatformMediaSessionManager when the WebProcess is suspended or resumed
+        https://bugs.webkit.org/show_bug.cgi?id=199160
+
+        Reviewed by Brent Fulgham.
+
+        When the WebProcess suspends or resumes, the PlatformMediaSessionManager is notified about this.
+        Avoid creating a new PlatformMediaSessionManager if it does not already exist.
+
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::actualPrepareToSuspend):
+        (WebKit::WebProcess::cancelPrepareToSuspend):
+        (WebKit::WebProcess::processDidResume):
+
 2019-06-24  Adrian Perez de Castro  <aperez@igalia.com>
 

trunk/Source/WebKit/WebProcess/WebProcess.cpp

@@ -1474 +1474 @@
 #if ENABLE(VIDEO)
     suspendAllMediaBuffering();
-    PlatformMediaSessionManager::sharedManager().processWillSuspend();
+    if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
+        platformMediaSessionManager->processWillSuspend();
 #endif
 
@@ -1536 +1537 @@
 
 #if ENABLE(VIDEO)
-    PlatformMediaSessionManager::sharedManager().processDidResume();
+    if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
+        platformMediaSessionManager->processDidResume();
     resumeAllMediaBuffering();
 #endif
@@ -1612 +1614 @@
 
 #if ENABLE(VIDEO)
-    PlatformMediaSessionManager::sharedManager().processDidResume();
+    if (auto* platformMediaSessionManager = PlatformMediaSessionManager::sharedManagerIfExists())
+        platformMediaSessionManager->processDidResume();
     resumeAllMediaBuffering();
 #endif