Changeset 246849 in webkit

Timestamp:

Jun 26, 2019, 3:11:30 PM (5 years ago)

Author:

graouts@webkit.org

Message:

[Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover
​https://bugs.webkit.org/show_bug.cgi?id=198999
<rdar://problem/51979477>

Reviewed by Dean Jackson.

Make sure we don't return early prior to setting the flag that prevents re-entrancy, or else we would never
enter this function again. No new tests, this was caught because Pointer Events WPT tests on iOS tests regressed.

• page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::processPendingPointerCapture):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/PointerCaptureController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-06-26  Antoine Quint  <graouts@apple.com>
+
+        [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover
+        https://bugs.webkit.org/show_bug.cgi?id=198999
+        <rdar://problem/51979477>
+
+        Reviewed by Dean Jackson.
+
+        Make sure we don't return early prior to setting the flag that prevents re-entrancy, or else we would never
+        enter this function again. No new tests, this was caught because Pointer Events WPT tests on iOS tests regressed.
+
+        * page/PointerCaptureController.cpp:
+        (WebCore::PointerCaptureController::processPendingPointerCapture):
+
 2019-06-26  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/page/PointerCaptureController.cpp

@@ -410 +410 @@
 void PointerCaptureController::processPendingPointerCapture(PointerID pointerId)
 {
+    auto iterator = m_activePointerIdsToCapturingData.find(pointerId);
+    if (iterator == m_activePointerIdsToCapturingData.end())
+        return;
+
     if (m_processingPendingPointerCapture)
         return;
 
     m_processingPendingPointerCapture = true;
-
-    auto iterator = m_activePointerIdsToCapturingData.find(pointerId);
-    if (iterator == m_activePointerIdsToCapturingData.end())
-        return;
 
     auto& capturingData = iterator->value;