Changeset 246942 in webkit
- Timestamp:
- Jun 28, 2019 3:24:23 PM (5 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r246941 r246942 1 2019-06-28 Alex Christensen <achristensen@webkit.org> 2 3 Make getHostnamesWithCookies more robust 4 https://bugs.webkit.org/show_bug.cgi?id=199334 5 <rdar://problem/51860593> 6 7 Reviewed by Brent Fulgham. 8 9 Crash logs suggest either httpCookies is returning a nil cookie or a cookie without a domain. 10 This should not happen, but if it does we shouldn't crash. 11 12 * platform/network/cocoa/NetworkStorageSessionCocoa.mm: 13 (WebCore::NetworkStorageSession::getHostnamesWithCookies): 14 1 15 2019-06-28 chris fleizach <cfleizach@apple.com> 2 16 -
trunk/Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm
r245796 r246942 488 488 NSArray *cookies = httpCookies(cookieStorage().get()); 489 489 490 for (NSHTTPCookie* cookie in cookies) 491 hostnames.add([cookie domain]); 490 for (NSHTTPCookie* cookie in cookies) { 491 if (NSString *domain = [cookie domain]) 492 hostnames.add(domain); 493 else 494 ASSERT_NOT_REACHED(); 495 } 492 496 493 497 END_BLOCK_OBJC_EXCEPTIONS;
Note: See TracChangeset
for help on using the changeset viewer.