Changeset 247075 in webkit

Timestamp:

Jul 2, 2019 4:03:11 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews-build] Allow skipping uploading built product for few builders
​https://bugs.webkit.org/show_bug.cgi?id=199422

Reviewed by Michael Catanzaro.

• BuildSlaveSupport/ews-build/steps.py:

(CompileWebKit.init): Added optional skipUpload parameter.
(CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -620 +620 @@
     command = ['perl', 'Tools/Scripts/build-webkit', WithProperties('--%(configuration)s')]
 
-    def __init__(self, **kwargs):
+    def __init__(self, skipUpload=False, **kwargs):
+        self.skipUpload = skipUpload
         super(CompileWebKit, self).__init__(logEnviron=False, **kwargs)
 
@@ -651 +652 @@
             self.build.addStepsAfterCurrentStep([UnApplyPatchIfRequired(), CompileWebKitToT(), AnalyzeCompileWebKitResults()])
         else:
-            self.build.addStepsAfterCurrentStep([ArchiveBuiltProduct(), UploadBuiltProduct(), TransferToS3()])
+            triggers = self.getProperty('triggers', None)
+            if triggers or not self.skipUpload:
+                self.build.addStepsAfterCurrentStep([ArchiveBuiltProduct(), UploadBuiltProduct(), TransferToS3()])
 
         return super(CompileWebKit, self).evaluateCommand(cmd)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-07-02  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Allow skipping uploading built product for few builders
+        https://bugs.webkit.org/show_bug.cgi?id=199422
+
+        Reviewed by Michael Catanzaro.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (CompileWebKit.__init__): Added optional skipUpload parameter.
+        (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
+
 2019-07-02  Tim Horton  <timothy_horton@apple.com>