Changeset 247139 in webkit

Timestamp:

Jul 4, 2019 6:28:45 AM (5 years ago)

Author:

clopez@igalia.com

Message:

[webkitpy] test-webkitpy is broken on Linux since r246662
​https://bugs.webkit.org/show_bug.cgi?id=199493

Reviewed by Michael Catanzaro.

• Scripts/webkitpy/test/main.py:

(_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/test/main.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [webkitpy] test-webkitpy is broken on Linux since r246662
+        https://bugs.webkit.org/show_bug.cgi?id=199493
+
+        Reviewed by Michael Catanzaro.
+
+        * Scripts/webkitpy/test/main.py:
+        (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
+
 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Tools/Scripts/webkitpy/test/main.py

@@ -105 +105 @@
     # FIXME: Remove when test-lldb is in its own script
     # https://bugs.webkit.org/show_bug.cgi?id=187916
-    return not _host.platform.build_version().startswith('19A')
+    build_version = _host.platform.build_version()
+    if build_version is None:
+        return False
+    return not build_version.startswith('19A')