Changeset 247175 in webkit

Timestamp:

Jul 5, 2019 2:30:31 PM (5 years ago)

Author:

ysuzuki@apple.com

Message:

Unreviewed, fix build failure on ARM64_32
​https://bugs.webkit.org/show_bug.cgi?id=182434

Implicit narrowing from uint64_t to uint32_t happens. We should explicitly narrow it because we already checked
the length is <= UINT32_MAX.

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSpeciesCreate):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/ArrayPrototype.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-07-05  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Unreviewed, fix build failure on ARM64_32
+        https://bugs.webkit.org/show_bug.cgi?id=182434
+
+        Implicit narrowing from uint64_t to uint32_t happens. We should explicitly narrow it because we already checked
+        the `length` is <= UINT32_MAX.
+
+        * runtime/ArrayPrototype.cpp:
+        (JSC::arrayProtoFuncSpeciesCreate):
+
 2019-07-05  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp

@@ -285 +285 @@
     }
 
-    RELEASE_AND_RETURN(scope, JSValue::encode(constructEmptyArray(exec, nullptr, length)));
+    RELEASE_AND_RETURN(scope, JSValue::encode(constructEmptyArray(exec, nullptr, static_cast<unsigned>(length))));
 }