Changeset 247207 in webkit

Timestamp:

Jul 8, 2019 4:47:13 AM (5 years ago)

Author:

cturner@igalia.com

Message:

[GStreamer] media/video-volume.html broken after switching from cubic to linear scaling
​https://bugs.webkit.org/show_bug.cgi?id=199505

Reviewed by Xabier Rodriguez-Calvar.

PulseAudio has a conversion process from volume's in
double-precision to uint32_t volumes. Depending on the environment
can introduce rounding errors. Be more lenient in our comparison
code.

• media/video-volume-expected.txt: Update baseline
• media/video-volume.html: Compare volume values within a

reasonable tolerance.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/video-volume-expected.txt (modified) (1 diff)
• media/video-volume.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-07-08  Charlie Turner  <cturner@igalia.com>
+
+        [GStreamer] media/video-volume.html broken after switching from cubic to linear scaling
+        https://bugs.webkit.org/show_bug.cgi?id=199505
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        PulseAudio has a conversion process from volume's in
+        double-precision to uint32_t volumes. Depending on the environment
+        can introduce rounding errors. Be more lenient in our comparison
+        code.
+
+        * media/video-volume-expected.txt: Update baseline
+        * media/video-volume.html: Compare volume values within a
+        reasonable tolerance.
+
 2019-07-08  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/media/video-volume-expected.txt

@@ -2 +2 @@
 Test 'volume' attribute
 
-EXPECTED (video.volume == '1') OK
+EXPECTED (compareWithTolerance(video.volume, 1.0) == 'true') OK
 RUN(video.volume = 0.5)
-EXPECTED (video.volume == '0.5') OK
+EXPECTED (compareWithTolerance(video.volume, 0.5) == 'true') OK
 RUN(video.volume = 0)
-EXPECTED (video.volume == '0') OK
+EXPECTED (compareWithTolerance(video.volume, 0) == 'true') OK
 TEST(video.volume = 1.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
 TEST(video.volume = -0.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
 RUN(video.load())
 EVENT(canplaythrough)
-EXPECTED (video.volume == '0') OK
+EXPECTED (compareWithTolerance(video.volume, 0) == 'true') OK
 RUN(video.volume = 0.5)
-EXPECTED (video.volume == '0.5') OK
+EXPECTED (compareWithTolerance(video.volume, 0.5) == 'true') OK
 TEST(video.volume = 1.5) THROWS(DOMException.INDEX_SIZE_ERR) OK
 TEST(video.volume = -0.5) THROWS(DOMException.INDEX_SIZE_ERR) OK

trunk/LayoutTests/media/video-volume.html

@@ -4 +4 @@
 <script src=video-test.js></script>
 <script>
-    testExpected("video.volume", 1.0);
+    function compareWithTolerance(a, b) {
+        tolerance = 0.00001;
+        return (Math.abs(a - b) < tolerance);
+    }
+    testExpected("compareWithTolerance(video.volume, 1.0)", true);
     run("video.volume = 0.5");
-    testExpected("video.volume", 0.5);
+    testExpected("compareWithTolerance(video.volume, 0.5)", true);
     run("video.volume = 0");
-    testExpected("video.volume", 0);
+    testExpected("compareWithTolerance(video.volume, 0)", true);
     testDOMException("video.volume = 1.5", "DOMException.INDEX_SIZE_ERR");
     testDOMException("video.volume = -0.5", "DOMException.INDEX_SIZE_ERR");
@@ -14 +18 @@
     run("video.load()");
     waitForEvent("canplaythrough", function () {
-        testExpected("video.volume", 0);
+        testExpected("compareWithTolerance(video.volume, 0)", true);
         run("video.volume = 0.5");
-        testExpected("video.volume", 0.5);
+        testExpected("compareWithTolerance(video.volume, 0.5)", true);
         testDOMException("video.volume = 1.5", "DOMException.INDEX_SIZE_ERR");
         testDOMException("video.volume = -0.5", "DOMException.INDEX_SIZE_ERR");