Changeset 247274 in webkit

Timestamp:

Jul 9, 2019 1:28:15 PM (5 years ago)

Author:

Chris Dumez

Message:

Fix validation of method signature in decodeInvocation()
​https://bugs.webkit.org/show_bug.cgi?id=199629
<rdar://problem/52731659>

Reviewed by Dan Bernstein.

The decoder was mistakenly assigning remoteMethodSignature to localMethodSignature
before comparing remoteMethodSignature and localMethodSignature, thus making the
check useless.

• Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(decodeInvocation):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/API/Cocoa/WKRemoteObjectCoder.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-09  Chris Dumez  <cdumez@apple.com>
+
+        Fix validation of method signature in decodeInvocation()
+        https://bugs.webkit.org/show_bug.cgi?id=199629
+        <rdar://problem/52731659>
+
+        Reviewed by Dan Bernstein.
+
+        The decoder was mistakenly assigning remoteMethodSignature to localMethodSignature
+        before comparing remoteMethodSignature and localMethodSignature, thus making the
+        check useless.
+
+        * Shared/API/Cocoa/WKRemoteObjectCoder.mm:
+        (decodeInvocation):
+
 2019-07-09  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm

@@ -608 +608 @@
 
     NSMethodSignature *remoteMethodSignature = [NSMethodSignature signatureWithObjCTypes:typeSignature.UTF8String];
-    localMethodSignature = remoteMethodSignature;
     if (![localMethodSignature isEqual:remoteMethodSignature])
         [NSException raise:NSInvalidUnarchiveOperationException format:@"Local and remote method signatures are not equal for method \"%s\"", selector ? sel_getName(selector) : "(no selector)"];