Changeset 247280 in webkit

Timestamp:

Jul 9, 2019 2:45:05 PM (5 years ago)

Author:

Megan Gardner

Message:

Don't strip out spaces for personalized Autocorrections
​https://bugs.webkit.org/show_bug.cgi?id=199476
<rdar://problem/50782015>

Reviewed by Dean Jackson.

When inserting 'autocorrections' that are really predictive
text suggestions based on personal data, we would remove the space
before the suggestion, resulting in incorrect input.
To fix, do not remove a space when the autocorrected text and the text it is
replacing do not have any length.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applyAutocorrectionInternal):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-09  Megan Gardner  <megan_gardner@apple.com>
+
+        Don't strip out spaces for personalized Autocorrections
+        https://bugs.webkit.org/show_bug.cgi?id=199476
+        <rdar://problem/50782015>
+
+        Reviewed by Dean Jackson.
+
+        When inserting 'autocorrections' that are really predictive
+        text suggestions based on personal data, we would remove the space
+        before the suggestion, resulting in incorrect input.
+        To fix, do not remove a space when the autocorrected text and the text it is 
+        replacing do not have any length.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::applyAutocorrectionInternal):
+
 2019-07-09  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -2369 +2369 @@
     if (correction.length())
         frame.editor().insertText(correction, 0, originalText.isEmpty() ? TextEventInputKeyboard : TextEventInputAutocompletion);
-    else
+    else if (originalText.length())
         frame.editor().deleteWithDirection(DirectionBackward, CharacterGranularity, false, true);
     return true;