Changeset 247317 in webkit


Ignore:
Timestamp:
Jul 10, 2019 12:46:05 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r247223.
https://bugs.webkit.org/show_bug.cgi?id=199679

Caused perf regression. (Requested by deanj on #webkit).

Reverted changeset:

"[iPadOS] Viewport pops while loading sohu.com, xinhuanet.com,
and various other websites"
https://bugs.webkit.org/show_bug.cgi?id=199575
https://trac.webkit.org/changeset/247223

Location:
trunk
Files:
2 deleted
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r247314 r247317  
     12019-07-10  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r247223.
     4        https://bugs.webkit.org/show_bug.cgi?id=199679
     5
     6        Caused perf regression. (Requested by deanj on #webkit).
     7
     8        Reverted changeset:
     9
     10        "[iPadOS] Viewport pops while loading sohu.com, xinhuanet.com,
     11        and various other websites"
     12        https://bugs.webkit.org/show_bug.cgi?id=199575
     13        https://trac.webkit.org/changeset/247223
     14
    1152019-07-10  Youenn Fablet  <youenn@apple.com>
    216
  • trunk/LayoutTests/fast/viewport/ios/shrink-to-fit-content-temporary-overflow.html

    r247223 r247317  
    4949description("This test verifies that a temporary change in content width does not cause the viewport width to permanently expand to try and accomodate the content. To test manually, load the page and check that the box below reads 'PASS'. This test is only intended to run on devices with less than 1200px screen width.");
    5050
    51 function forceLayoutByScrollingTo(y) {
    52     document.scrollingElement.scrollTo(0, y);
    53     return document.scrollingElement.scrollTop;
    54 }
    55 
    56 addEventListener("DOMContentLoaded", () => {
    57     forceLayoutByScrollingTo(1);
    58     const bar = document.createElement("div");
    59     bar.classList.add("bar");
    60     document.body.appendChild(bar);
    61     forceLayoutByScrollingTo(0);
    62     bar.remove();
    63 });
    64 
    6551addEventListener("load", async () => {
    6652    if (!window.testRunner)
     
    7763<div id="description"></div>
    7864<div class="square"></div>
     65<script>
     66const bar = document.createElement("div");
     67bar.classList.add("bar");
     68document.body.appendChild(bar);
     69document.scrollingElement.scrollTo(0, 1);
     70document.scrollingElement.scrollTo(0, 0);
     71document.scrollingElement.scrollTop;
     72bar.remove();
     73</script>
    7974</body>
    8075</html>
  • trunk/Source/WebKit/ChangeLog

    r247314 r247317  
     12019-07-10  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r247223.
     4        https://bugs.webkit.org/show_bug.cgi?id=199679
     5
     6        Caused perf regression. (Requested by deanj on #webkit).
     7
     8        Reverted changeset:
     9
     10        "[iPadOS] Viewport pops while loading sohu.com, xinhuanet.com,
     11        and various other websites"
     12        https://bugs.webkit.org/show_bug.cgi?id=199575
     13        https://trac.webkit.org/changeset/247223
     14
    1152019-07-10  Youenn Fablet  <youenn@apple.com>
    216
  • trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

    r247223 r247317  
    615615    // Notify the UIProcess.
    616616    webPage->send(Messages::WebPageProxy::DidFinishDocumentLoadForFrame(m_frame->frameID(), navigationID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get())));
     617
     618    webPage->didFinishDocumentLoad(*m_frame);
    617619}
    618620
  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

    r247223 r247317  
    32713271void WebPage::didCompletePageTransition()
    32723272{
    3273 #if ENABLE(VIEWPORT_RESIZING)
    3274     if (immediatelyShrinkToFitContent())
    3275         viewportConfigurationChanged(ZoomToInitialScale::Yes);
    3276 #endif
    3277 
    32783273    unfreezeLayerTree(LayerTreeFreezeReason::PageTransition);
    32793274
     
    58015796}
    58025797
     5798void WebPage::didFinishDocumentLoad(WebFrame& frame)
     5799{
     5800    if (!frame.isMainFrame())
     5801        return;
     5802
     5803#if ENABLE(VIEWPORT_RESIZING)
     5804    scheduleShrinkToFitContent();
     5805#endif
     5806}
     5807
    58035808void WebPage::didFinishLoad(WebFrame& frame)
    58045809{
  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.h

    r247223 r247317  
    360360    void willReplaceMultipartContent(const WebFrame&);
    361361    void didReplaceMultipartContent(const WebFrame&);
     362    void didFinishDocumentLoad(WebFrame&);
    362363    void didFinishLoad(WebFrame&);
    363364    void show();
  • trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

    r247291 r247317  
    33213321        return false;
    33223322
    3323     if (!m_mainFrame)
    3324         return false;
    3325 
    33263323    if (!m_page->settings().allowViewportShrinkToFitContent())
    33273324        return false;
Note: See TracChangeset for help on using the changeset viewer.