Changeset 247317 in webkit
- Timestamp:
- Jul 10, 2019 12:46:05 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 deleted
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r247314 r247317 1 2019-07-10 Commit Queue <commit-queue@webkit.org> 2 3 Unreviewed, rolling out r247223. 4 https://bugs.webkit.org/show_bug.cgi?id=199679 5 6 Caused perf regression. (Requested by deanj on #webkit). 7 8 Reverted changeset: 9 10 "[iPadOS] Viewport pops while loading sohu.com, xinhuanet.com, 11 and various other websites" 12 https://bugs.webkit.org/show_bug.cgi?id=199575 13 https://trac.webkit.org/changeset/247223 14 1 15 2019-07-10 Youenn Fablet <youenn@apple.com> 2 16 -
trunk/LayoutTests/fast/viewport/ios/shrink-to-fit-content-temporary-overflow.html
r247223 r247317 49 49 description("This test verifies that a temporary change in content width does not cause the viewport width to permanently expand to try and accomodate the content. To test manually, load the page and check that the box below reads 'PASS'. This test is only intended to run on devices with less than 1200px screen width."); 50 50 51 function forceLayoutByScrollingTo(y) {52 document.scrollingElement.scrollTo(0, y);53 return document.scrollingElement.scrollTop;54 }55 56 addEventListener("DOMContentLoaded", () => {57 forceLayoutByScrollingTo(1);58 const bar = document.createElement("div");59 bar.classList.add("bar");60 document.body.appendChild(bar);61 forceLayoutByScrollingTo(0);62 bar.remove();63 });64 65 51 addEventListener("load", async () => { 66 52 if (!window.testRunner) … … 77 63 <div id="description"></div> 78 64 <div class="square"></div> 65 <script> 66 const bar = document.createElement("div"); 67 bar.classList.add("bar"); 68 document.body.appendChild(bar); 69 document.scrollingElement.scrollTo(0, 1); 70 document.scrollingElement.scrollTo(0, 0); 71 document.scrollingElement.scrollTop; 72 bar.remove(); 73 </script> 79 74 </body> 80 75 </html> -
trunk/Source/WebKit/ChangeLog
r247314 r247317 1 2019-07-10 Commit Queue <commit-queue@webkit.org> 2 3 Unreviewed, rolling out r247223. 4 https://bugs.webkit.org/show_bug.cgi?id=199679 5 6 Caused perf regression. (Requested by deanj on #webkit). 7 8 Reverted changeset: 9 10 "[iPadOS] Viewport pops while loading sohu.com, xinhuanet.com, 11 and various other websites" 12 https://bugs.webkit.org/show_bug.cgi?id=199575 13 https://trac.webkit.org/changeset/247223 14 1 15 2019-07-10 Youenn Fablet <youenn@apple.com> 2 16 -
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
r247223 r247317 615 615 // Notify the UIProcess. 616 616 webPage->send(Messages::WebPageProxy::DidFinishDocumentLoadForFrame(m_frame->frameID(), navigationID, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get()))); 617 618 webPage->didFinishDocumentLoad(*m_frame); 617 619 } 618 620 -
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
r247223 r247317 3271 3271 void WebPage::didCompletePageTransition() 3272 3272 { 3273 #if ENABLE(VIEWPORT_RESIZING)3274 if (immediatelyShrinkToFitContent())3275 viewportConfigurationChanged(ZoomToInitialScale::Yes);3276 #endif3277 3278 3273 unfreezeLayerTree(LayerTreeFreezeReason::PageTransition); 3279 3274 … … 5801 5796 } 5802 5797 5798 void WebPage::didFinishDocumentLoad(WebFrame& frame) 5799 { 5800 if (!frame.isMainFrame()) 5801 return; 5802 5803 #if ENABLE(VIEWPORT_RESIZING) 5804 scheduleShrinkToFitContent(); 5805 #endif 5806 } 5807 5803 5808 void WebPage::didFinishLoad(WebFrame& frame) 5804 5809 { -
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
r247223 r247317 360 360 void willReplaceMultipartContent(const WebFrame&); 361 361 void didReplaceMultipartContent(const WebFrame&); 362 void didFinishDocumentLoad(WebFrame&); 362 363 void didFinishLoad(WebFrame&); 363 364 void show(); -
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
r247291 r247317 3321 3321 return false; 3322 3322 3323 if (!m_mainFrame)3324 return false;3325 3326 3323 if (!m_page->settings().allowViewportShrinkToFitContent()) 3327 3324 return false;
Note: See TracChangeset
for help on using the changeset viewer.