Changeset 247330 in webkit

Timestamp:

Jul 10, 2019 3:42:21 PM (5 years ago)

Author:

Chris Fleizach

Message:

AX: VoiceOver ignored role="presentation" on <table> HTML elements
​https://bugs.webkit.org/show_bug.cgi?id=199659

Reviewed by Zalan Bujtas.

Source/WebCore:

Only include a table ancestor if it's a table we care about for accessibility.

Modified Test: accessibility/ios-simulator/tables-lists.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):

LayoutTests:

• accessibility/ios-simulator/tables-lists-expected.txt:
• accessibility/ios-simulator/tables-lists.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/ios-simulator/tables-lists-expected.txt (modified) (2 diffs)
• LayoutTests/accessibility/ios-simulator/tables-lists.html (modified) (3 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-07-10  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: VoiceOver ignored role="presentation" on <table> HTML elements
+        https://bugs.webkit.org/show_bug.cgi?id=199659
+
+        Reviewed by Zalan Bujtas.
+
+        * accessibility/ios-simulator/tables-lists-expected.txt:
+        * accessibility/ios-simulator/tables-lists.html:
+
 2019-07-10  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/accessibility/ios-simulator/tables-lists-expected.txt

@@ -3 +3 @@
 table item 1    table item 2    table item 3
 landmark 1
+table item 1
 This test makes sure that items in lists, tables and landmarks have different traits on them, because they're contained in different items.
 
@@ -14 +15 @@
 PASS tableItem.traits != landmarkItem.traits is true
 PASS landmarkItem.traits != initialItem.traits is true
+PASS nonTableItem.traits != tableItem.traits is true
 PASS successfullyParsed is true
 

trunk/LayoutTests/accessibility/ios-simulator/tables-lists.html

@@ -27 +27 @@
 </div>
 
+<table border=1 role="presentation">
+<tr role="presentation"><td role="presentation">table item 1</td></tr>
+</table>
+
 </div>
 
@@ -44 +48 @@
         var tableItem = root.childAtIndex(2).childAtIndex(0);
         var landmarkItem = root.childAtIndex(3).childAtIndex(0);
+        var nonTableItem = root.childAtIndex(4);
 
         shouldBe("listItem.traits != initialItem.traits", "true");
@@ -53 +58 @@
 
         shouldBe("landmarkItem.traits != initialItem.traits", "true");
+
+        shouldBe("nonTableItem.traits != tableItem.traits", "true");
     }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-10  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: VoiceOver ignored role="presentation" on <table> HTML elements
+        https://bugs.webkit.org/show_bug.cgi?id=199659
+
+        Reviewed by Zalan Bujtas.
+
+        Only include a table ancestor if it's a table we care about for accessibility.
+
+        Modified Test: accessibility/ios-simulator/tables-lists.html
+
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
+
 2019-07-10  Robin Morisset  <rmorisset@apple.com>
 

trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

@@ -593 +593 @@
 - (AccessibilityObjectWrapper*)_accessibilityTableAncestor
 {
-    
     if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) {
-        return object.isTable();
+        return object.roleValue() == AccessibilityRole::Table;
     }))
         return parent->wrapper();